[Profiles] Send out less profile avatar related notifications

chrome/browser/profiles/profile_info_cache.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_PROFILES_PROFILE_INFO_CACHE_H_
 #define CHROME_BROWSER_PROFILES_PROFILE_INFO_CACHE_H_
 
 #include <map>
 #include <string>
 #include <vector>
@@ skipping 118 matching lines @@
 
   // Gets all names of profiles associated with this instance of Chrome.
   // Because this method will be called during uninstall, before the creation
   // of the ProfileManager, it reads directly from the local state preferences,
   // rather than going through the ProfileInfoCache object.
   static std::vector<base::string16> GetProfileNames();
 
   // Register cache related preferences in Local State.
   static void RegisterPrefs(PrefRegistrySimple* registry);
 
-  // Starts downloading the high res avatar at index |icon_index| for profile
-  // with path |profile_path|.
-  void DownloadHighResAvatar(size_t icon_index,
-                             const base::FilePath& profile_path);
+  // Checks whether the high res avatar at index |icon_index| exists, and
+  // if it does not, calls |DownloadHighResAvatar|.
+  void DownloadHighResAvatarIfNeeded(size_t icon_index,
+                                     const base::FilePath& profile_path);
 
   // Saves the avatar |image| at |image_path|. This is used both for the
   // GAIA profile pictures and the ProfileAvatarDownloader that is used to
   // download the high res avatars.
   void SaveAvatarImageAtPath(const gfx::Image* image,
                              const std::string& key,
                              const base::FilePath& image_path,
                              const base::FilePath& profile_path);
 
   void AddObserver(ProfileInfoCacheObserver* obs);
@@ skipping 24 matching lines @@
                                           size_t* out_icon_index) const;
 
   // Updates the position of the profile at the given index so that the list
   // of profiles is still sorted.
   void UpdateSortForProfileIndex(size_t index);
 
   // Loads or uses an already loaded high resolution image of the
   // generic profile avatar.
   const gfx::Image* GetHighResAvatarOfProfileAtIndex(size_t index) const;
 
+  // Starts downloading the high res avatar at index |icon_index| for profile
+  // with path |profile_path|.
+  void DownloadHighResAvatar(const std::string file_name,

[Mike Lerman, 2015/01/27 16:39:15]

nit: mention |file_name| in the comment, for completeness.

Also, file_name should be const std::string&, not merely const std::string.
(Note: &)

[noms (inactive), 2015/01/28 02:18:35]

Done.

+                             size_t icon_index,
+                             const base::FilePath& profile_path);
+
   // Returns the decoded image at |image_path|. Used both by the GAIA profile
   // image and the high res avatars.
   const gfx::Image* LoadAvatarPictureFromPath(
       const base::FilePath& profile_path,
       const std::string& key,
       const base::FilePath& image_path) const;
 
   // Called when the picture given by |key| has been loaded from disk and
   // decoded into |image|.
   void OnAvatarPictureLoaded(const base::FilePath& profile_path,
@@ skipping 27 matching lines @@
   // This prevents a picture from being downloaded multiple times. The
   // ProfileAvatarDownloader instances are deleted when the download completes
   // or when the ProfileInfoCache is destroyed.
   mutable std::map<std::string, ProfileAvatarDownloader*>
       avatar_images_downloads_in_progress_;
 
   DISALLOW_COPY_AND_ASSIGN(ProfileInfoCache);
 };
 
 #endif  // CHROME_BROWSER_PROFILES_PROFILE_INFO_CACHE_H_