Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 860983004: text input focus: Supports Window::GetFocusedTextInputClient. (Closed)

Created:
5 years, 11 months ago by Yuki
Modified:
5 years, 11 months ago
Reviewers:
msw, oshima, sky, sadrul, no sievers
CC:
chromium-reviews, tdanderson+views_chromium.org, sadrul, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, tfarina, jam, penghuang+watch_chromium.org, dcheng, sievers+watch_chromium.org, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, kalyank, danakj+watch_chromium.org, James Su
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

text input focus: Supports Window::GetFocusedTextInputClient. This CL is split off from http://crrev.com/785463002 and Window::GetFocusedTextInputClient is necessary in that CL. BUG=290701 Committed: https://crrev.com/907eabfaac97bcf997667debe79a5688ced0cb45 Cr-Commit-Position: refs/heads/master@{#313448}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -4 lines) Patch
M ash/display/cursor_window_controller.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ash/drag_drop/drag_drop_controller.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ash/root_window_controller.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/web_contents/aura/image_window_delegate.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/web_contents/aura/image_window_delegate.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/web_contents/web_contents_view_aura.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/web_contents/web_contents_view_aura.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/aura/demo/demo_main.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ui/aura/test/test_window_delegate.h View 3 chunks +3 lines, -0 lines 0 comments Download
M ui/aura/test/test_window_delegate.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/aura/window.h View 2 chunks +5 lines, -0 lines 0 comments Download
M ui/aura/window.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/aura/window_delegate.h View 2 chunks +5 lines, -0 lines 0 comments Download
M ui/keyboard/keyboard_controller.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/views/controls/native/native_view_host_aura.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_native_widget_aura.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_native_widget_aura.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/views/widget/native_widget_aura.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/widget/native_widget_aura.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/views/widget/widget.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/views/widget/widget.cc View 2 chunks +9 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
Yuki
Could you guys review this CL?
5 years, 11 months ago (2015-01-21 14:27:59 UTC) #2
Yuki
sadrul@, sky@, could you guys review this CL?
5 years, 11 months ago (2015-01-24 10:51:47 UTC) #3
sadrul
lgtm
5 years, 11 months ago (2015-01-26 18:51:58 UTC) #4
Yuki
oshima@ and sievers@, could you guys review this CL as owners? oshima@ ash/ sievers@ content/
5 years, 11 months ago (2015-01-27 07:46:21 UTC) #7
Yuki
oshima@ and sievers@, could you guys review this CL as owners? oshima@ ash/ sievers@ content/
5 years, 11 months ago (2015-01-27 07:46:22 UTC) #8
no sievers
On 2015/01/27 07:46:22, Yuki wrote: > oshima@ and sievers@, could you guys review this CL ...
5 years, 11 months ago (2015-01-27 20:03:48 UTC) #9
oshima
ash lgtm
5 years, 11 months ago (2015-01-27 22:37:05 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/860983004/1
5 years, 11 months ago (2015-01-28 04:16:40 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-28 04:31:44 UTC) #13
commit-bot: I haz the power
5 years, 11 months ago (2015-01-28 04:32:48 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/907eabfaac97bcf997667debe79a5688ced0cb45
Cr-Commit-Position: refs/heads/master@{#313448}

Powered by Google App Engine
This is Rietveld 408576698