Issue 860883002: Version 3.31.74.2 (cherry-pick)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 860883002: Version 3.31.74.2 (cherry-pick) (Closed)

Created:
5 years, 11 months ago by akos.palfi.imgtec

Modified:
5 years, 11 months ago

Reviewers:
Michael Achenbach, balazs.kilvady, dusmil.imgtec, danno, Jakob Kummerow, gergely.kis.imgtec, paul.l...

CC:
v8-dev, ulan

Base URL:
https://chromium.googlesource.com/v8/v8.git@3.31

Target Ref:
refs/pending/branch-heads/3.31

Project:
v8

Visibility:
Public.

More Reviews

Description

Version 3.31.74.2 (cherry-pick) Merged eb68d6fe13f13b0697dd2b4ff00df1d7c997669e Merged 466ed3a34d61dfe108a246e26df986e4986bd4a9 MIPS: remove immediate constraint within CompareAndSwap. MIPS: Fix 'MIPS: Fix after 'Reland remaining parts of 'Use weak cells in map checks in polymorphic ICs''.' R=machenbach@chromium.org BUG=

Patch Set 1 #

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -6 lines)			Patch
M	src/base/atomicops_internals_mips64_gcc.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/base/atomicops_internals_mips_gcc.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/ic/mips/ic-compiler-mips.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/ic/mips64/ic-compiler-mips64.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/version.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Jakob Kummerow

Not LGTM. You want to merge to the 4.1 branch instead.

5 years, 11 months ago (2015-01-21 09:23:38 UTC) #5

akos.palfi.imgtec

5 years, 11 months ago (2015-01-21 11:23:49 UTC) #6

Thanks, closing this CL..

Uploaded a new for 4.1: https://codereview.chromium.org/856353002/

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages