Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 860853003: Upstream support for giflib >= 5.1. (Closed)

Created:
5 years, 11 months ago by mtklein_C
Modified:
5 years, 11 months ago
Reviewers:
scroggo
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Upstream support for giflib >= 5.1. DGifCloseFile now takes two arugments. The second argument appears to be an optional out-param with more information on failures. ( c.f. http://giflib.sourceforge.net/gif_lib.html ) PS 1 is the original patch we received from google3. I've updated it a bit to be pedantically legal C++98. BUG=skia: Committed: https://skia.googlesource.com/skia/+/59c69479d44242350b303714a2cec8764c7f11a3

Patch Set 1 #

Patch Set 2 : 98 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -3 lines) Patch
M src/images/SkImageDecoder_libgif.cpp View 1 2 chunks +10 lines, -1 line 0 comments Download
M src/images/SkMovie_gif.cpp View 3 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/860853003/1
5 years, 11 months ago (2015-01-20 18:49:51 UTC) #2
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 11 months ago (2015-01-20 18:49:52 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu13.10-GCE-NoGPU-x86_64-Debug-Trybot on client.skia (http://build.chromium.org/p/client.skia/builders/Test-Ubuntu13.10-GCE-NoGPU-x86_64-Debug-Trybot/builds/1641) Test-Ubuntu13.10-GCE-NoGPU-x86_64-Release-Shared-Trybot on client.skia (http://build.chromium.org/p/client.skia/builders/Test-Ubuntu13.10-GCE-NoGPU-x86_64-Release-Shared-Trybot/builds/1612) Build-Ubuntu13.10-GCC4.8-Arm7-Debug-Android-Trybot ...
5 years, 11 months ago (2015-01-20 18:51:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/860853003/20001
5 years, 11 months ago (2015-01-20 18:53:51 UTC) #7
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 11 months ago (2015-01-20 18:53:52 UTC) #8
mtklein_C
5 years, 11 months ago (2015-01-20 19:02:17 UTC) #10
scroggo
LGTM FYI: If you want a Skia bug to attach, it's BUG=skia:2776
5 years, 11 months ago (2015-01-20 20:37:49 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/59c69479d44242350b303714a2cec8764c7f11a3
5 years, 11 months ago (2015-01-20 20:38:09 UTC) #12
mtklein
5 years, 11 months ago (2015-01-20 20:40:34 UTC) #13
Message was sent while issue was closed.
On 2015/01/20 20:37:49, scroggo wrote:
> LGTM
> 
> FYI: If you want a Skia bug to attach, it's
> 
> BUG=skia:2776

Ooh, nice!

Powered by Google App Engine
This is Rietveld 408576698