Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Side by Side Diff: cc/resources/gpu_tile_task_worker_pool.h

Issue 860813002: Remove the default format from ResourcePool. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix compile error in perftest. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CC_RESOURCES_GPU_TILE_TASK_WORKER_POOL_H_ 5 #ifndef CC_RESOURCES_GPU_TILE_TASK_WORKER_POOL_H_
6 #define CC_RESOURCES_GPU_TILE_TASK_WORKER_POOL_H_ 6 #define CC_RESOURCES_GPU_TILE_TASK_WORKER_POOL_H_
7 7
8 #include "base/memory/weak_ptr.h" 8 #include "base/memory/weak_ptr.h"
9 #include "cc/resources/tile_task_runner.h" 9 #include "cc/resources/tile_task_runner.h"
10 #include "cc/resources/tile_task_worker_pool.h" 10 #include "cc/resources/tile_task_worker_pool.h"
11 11
12 namespace cc { 12 namespace cc {
13 13
14 class CC_EXPORT GpuTileTaskWorkerPool : public TileTaskWorkerPool, 14 class CC_EXPORT GpuTileTaskWorkerPool : public TileTaskWorkerPool,
15 public TileTaskRunner, 15 public TileTaskRunner,
16 public TileTaskClient { 16 public TileTaskClient {
17 public: 17 public:
18 ~GpuTileTaskWorkerPool() override; 18 ~GpuTileTaskWorkerPool() override;
19 19
20 static scoped_ptr<TileTaskWorkerPool> Create( 20 static scoped_ptr<TileTaskWorkerPool> Create(
21 base::SequencedTaskRunner* task_runner, 21 base::SequencedTaskRunner* task_runner,
22 TaskGraphRunner* task_graph_runner); 22 TaskGraphRunner* task_graph_runner,
23 ResourceFormat resource_format);
reveman 2015/01/22 23:01:46 Can this just use resource_provider->best_texture_
peterp 2015/01/23 13:19:06 Then we have to pass in and store the ResourceProv
23 24
24 // Overridden from TileTaskWorkerPool: 25 // Overridden from TileTaskWorkerPool:
25 TileTaskRunner* AsTileTaskRunner() override; 26 TileTaskRunner* AsTileTaskRunner() override;
27 ResourceFormat GetResourceFormat() override;
26 28
27 // Overridden from TileTaskRunner: 29 // Overridden from TileTaskRunner:
28 void SetClient(TileTaskRunnerClient* client) override; 30 void SetClient(TileTaskRunnerClient* client) override;
29 void Shutdown() override; 31 void Shutdown() override;
30 void ScheduleTasks(TileTaskQueue* queue) override; 32 void ScheduleTasks(TileTaskQueue* queue) override;
31 void CheckForCompletedTasks() override; 33 void CheckForCompletedTasks() override;
32 34
33 // Overridden from TileTaskClient: 35 // Overridden from TileTaskClient:
34 scoped_ptr<RasterBuffer> AcquireBufferForRaster( 36 scoped_ptr<RasterBuffer> AcquireBufferForRaster(
35 const Resource* resource) override; 37 const Resource* resource) override;
36 void ReleaseBufferForRaster(scoped_ptr<RasterBuffer> buffer) override; 38 void ReleaseBufferForRaster(scoped_ptr<RasterBuffer> buffer) override;
37 39
38 private: 40 private:
39 GpuTileTaskWorkerPool(base::SequencedTaskRunner* task_runner, 41 GpuTileTaskWorkerPool(base::SequencedTaskRunner* task_runner,
40 TaskGraphRunner* task_graph_runner); 42 TaskGraphRunner* task_graph_runner,
43 ResourceFormat resource_format);
41 44
42 void OnTaskSetFinished(TaskSet task_set); 45 void OnTaskSetFinished(TaskSet task_set);
43 void CompleteTasks(const Task::Vector& tasks); 46 void CompleteTasks(const Task::Vector& tasks);
44 47
45 scoped_refptr<base::SequencedTaskRunner> task_runner_; 48 scoped_refptr<base::SequencedTaskRunner> task_runner_;
46 TaskGraphRunner* task_graph_runner_; 49 TaskGraphRunner* task_graph_runner_;
47 const NamespaceToken namespace_token_; 50 const NamespaceToken namespace_token_;
48 TileTaskRunnerClient* client_; 51 TileTaskRunnerClient* client_;
52 ResourceFormat resource_format_;
49 53
50 TaskSetCollection tasks_pending_; 54 TaskSetCollection tasks_pending_;
51 55
52 scoped_refptr<TileTask> task_set_finished_tasks_[kNumberOfTaskSets]; 56 scoped_refptr<TileTask> task_set_finished_tasks_[kNumberOfTaskSets];
53 57
54 // Task graph used when scheduling tasks and vector used to gather 58 // Task graph used when scheduling tasks and vector used to gather
55 // completed tasks. 59 // completed tasks.
56 TaskGraph graph_; 60 TaskGraph graph_;
57 Task::Vector completed_tasks_; 61 Task::Vector completed_tasks_;
58 62
59 base::WeakPtrFactory<GpuTileTaskWorkerPool> 63 base::WeakPtrFactory<GpuTileTaskWorkerPool>
60 task_set_finished_weak_ptr_factory_; 64 task_set_finished_weak_ptr_factory_;
61 65
62 base::WeakPtrFactory<GpuTileTaskWorkerPool> weak_ptr_factory_; 66 base::WeakPtrFactory<GpuTileTaskWorkerPool> weak_ptr_factory_;
63 67
64 DISALLOW_COPY_AND_ASSIGN(GpuTileTaskWorkerPool); 68 DISALLOW_COPY_AND_ASSIGN(GpuTileTaskWorkerPool);
65 }; 69 };
66 70
67 } // namespace cc 71 } // namespace cc
68 72
69 #endif // CC_RESOURCES_GPU_TILE_TASK_WORKER_POOL_H_ 73 #endif // CC_RESOURCES_GPU_TILE_TASK_WORKER_POOL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698