Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(660)

Side by Side Diff: cc/resources/one_copy_tile_task_worker_pool.cc

Issue 860813002: Remove the default format from ResourcePool. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove ResourceFormat from TileManager and call TileTaskRunner::GetResourceFormat() directly instea… Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "cc/resources/one_copy_tile_task_worker_pool.h" 5 #include "cc/resources/one_copy_tile_task_worker_pool.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <limits> 8 #include <limits>
9 9
10 #include "base/debug/trace_event.h" 10 #include "base/debug/trace_event.h"
11 #include "base/debug/trace_event_argument.h" 11 #include "base/debug/trace_event_argument.h"
12 #include "base/strings/stringprintf.h" 12 #include "base/strings/stringprintf.h"
13 #include "cc/debug/traced_value.h" 13 #include "cc/debug/traced_value.h"
14 #include "cc/resources/raster_buffer.h" 14 #include "cc/resources/raster_buffer.h"
15 #include "cc/resources/resource_pool.h" 15 #include "cc/resources/resource_pool.h"
16 #include "cc/resources/scoped_resource.h" 16 #include "cc/resources/scoped_resource.h"
17 #include "gpu/command_buffer/client/gles2_interface.h" 17 #include "gpu/command_buffer/client/gles2_interface.h"
18 #include "ui/gfx/gpu_memory_buffer.h" 18 #include "ui/gfx/gpu_memory_buffer.h"
19 19
20 namespace cc { 20 namespace cc {
21 namespace { 21 namespace {
22 22
23 class RasterBufferImpl : public RasterBuffer { 23 class RasterBufferImpl : public RasterBuffer {
24 public: 24 public:
25 RasterBufferImpl(OneCopyTileTaskWorkerPool* worker_pool, 25 RasterBufferImpl(OneCopyTileTaskWorkerPool* worker_pool,
26 ResourceProvider* resource_provider, 26 ResourceProvider* resource_provider,
27 ResourcePool* resource_pool, 27 ResourcePool* resource_pool,
28 ResourceFormat resource_format,
28 const Resource* resource) 29 const Resource* resource)
29 : worker_pool_(worker_pool), 30 : worker_pool_(worker_pool),
30 resource_provider_(resource_provider), 31 resource_provider_(resource_provider),
31 resource_pool_(resource_pool), 32 resource_pool_(resource_pool),
32 resource_(resource), 33 resource_(resource),
33 raster_resource_( 34 raster_resource_(
34 resource_pool->AcquireResource(resource->size(), 35 resource_pool->AcquireResource(resource->size(), resource_format)),
35 resource_pool->default_format())),
36 lock_(new ResourceProvider::ScopedWriteLockGpuMemoryBuffer( 36 lock_(new ResourceProvider::ScopedWriteLockGpuMemoryBuffer(
37 resource_provider_, 37 resource_provider_,
38 raster_resource_->id())), 38 raster_resource_->id())),
39 sequence_(0) {} 39 sequence_(0) {}
40 40
41 ~RasterBufferImpl() override { 41 ~RasterBufferImpl() override {
42 // Release write lock in case a copy was never scheduled. 42 // Release write lock in case a copy was never scheduled.
43 lock_.reset(); 43 lock_.reset();
44 44
45 // Make sure any scheduled copy operations are issued before we release the 45 // Make sure any scheduled copy operations are issued before we release the
(...skipping 196 matching lines...) Expand 10 before | Expand all | Expand 10 after
242 242
243 task->WillComplete(); 243 task->WillComplete();
244 task->CompleteOnOriginThread(this); 244 task->CompleteOnOriginThread(this);
245 task->DidComplete(); 245 task->DidComplete();
246 246
247 task->RunReplyOnOriginThread(); 247 task->RunReplyOnOriginThread();
248 } 248 }
249 completed_tasks_.clear(); 249 completed_tasks_.clear();
250 } 250 }
251 251
252 ResourceFormat OneCopyTileTaskWorkerPool::GetResourceFormat() {
253 return resource_provider_->best_texture_format();
254 }
255
252 scoped_ptr<RasterBuffer> OneCopyTileTaskWorkerPool::AcquireBufferForRaster( 256 scoped_ptr<RasterBuffer> OneCopyTileTaskWorkerPool::AcquireBufferForRaster(
253 const Resource* resource) { 257 const Resource* resource) {
254 DCHECK_EQ(resource->format(), resource_pool_->default_format()); 258 DCHECK_EQ(resource->format(), resource_provider_->best_texture_format());
255 return make_scoped_ptr<RasterBuffer>( 259 return make_scoped_ptr<RasterBuffer>(
256 new RasterBufferImpl(this, resource_provider_, resource_pool_, resource)); 260 new RasterBufferImpl(this, resource_provider_, resource_pool_,
261 resource_provider_->best_texture_format(),
262 resource));
257 } 263 }
258 264
259 void OneCopyTileTaskWorkerPool::ReleaseBufferForRaster( 265 void OneCopyTileTaskWorkerPool::ReleaseBufferForRaster(
260 scoped_ptr<RasterBuffer> buffer) { 266 scoped_ptr<RasterBuffer> buffer) {
261 // Nothing to do here. RasterBufferImpl destructor cleans up after itself. 267 // Nothing to do here. RasterBufferImpl destructor cleans up after itself.
262 } 268 }
263 269
264 CopySequenceNumber 270 CopySequenceNumber
265 OneCopyTileTaskWorkerPool::PlaybackAndScheduleCopyOnWorkerThread( 271 OneCopyTileTaskWorkerPool::PlaybackAndScheduleCopyOnWorkerThread(
266 scoped_ptr<ResourceProvider::ScopedWriteLockGpuMemoryBuffer> write_lock, 272 scoped_ptr<ResourceProvider::ScopedWriteLockGpuMemoryBuffer> write_lock,
(...skipping 217 matching lines...) Expand 10 before | Expand all | Expand 10 after
484 resource_pool_->total_memory_usage_bytes()); 490 resource_pool_->total_memory_usage_bytes());
485 staging_state->SetInteger("pending_copy_count", 491 staging_state->SetInteger("pending_copy_count",
486 resource_pool_->total_resource_count() - 492 resource_pool_->total_resource_count() -
487 resource_pool_->acquired_resource_count()); 493 resource_pool_->acquired_resource_count());
488 staging_state->SetInteger("bytes_pending_copy", 494 staging_state->SetInteger("bytes_pending_copy",
489 resource_pool_->total_memory_usage_bytes() - 495 resource_pool_->total_memory_usage_bytes() -
490 resource_pool_->acquired_memory_usage_bytes()); 496 resource_pool_->acquired_memory_usage_bytes());
491 } 497 }
492 498
493 } // namespace cc 499 } // namespace cc
OLDNEW
« no previous file with comments | « cc/resources/one_copy_tile_task_worker_pool.h ('k') | cc/resources/pixel_buffer_tile_task_worker_pool.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698