Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Side by Side Diff: cc/resources/one_copy_tile_task_worker_pool.cc

Issue 860813002: Remove the default format from ResourcePool. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "cc/resources/one_copy_tile_task_worker_pool.h" 5 #include "cc/resources/one_copy_tile_task_worker_pool.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <limits> 8 #include <limits>
9 9
10 #include "base/debug/trace_event.h" 10 #include "base/debug/trace_event.h"
11 #include "base/debug/trace_event_argument.h" 11 #include "base/debug/trace_event_argument.h"
12 #include "base/strings/stringprintf.h" 12 #include "base/strings/stringprintf.h"
13 #include "cc/debug/traced_value.h" 13 #include "cc/debug/traced_value.h"
14 #include "cc/resources/raster_buffer.h" 14 #include "cc/resources/raster_buffer.h"
15 #include "cc/resources/resource_pool.h" 15 #include "cc/resources/resource_pool.h"
16 #include "cc/resources/scoped_resource.h" 16 #include "cc/resources/scoped_resource.h"
17 #include "gpu/command_buffer/client/gles2_interface.h" 17 #include "gpu/command_buffer/client/gles2_interface.h"
18 #include "ui/gfx/gpu_memory_buffer.h" 18 #include "ui/gfx/gpu_memory_buffer.h"
19 19
20 namespace cc { 20 namespace cc {
21 namespace { 21 namespace {
22 22
23 class RasterBufferImpl : public RasterBuffer { 23 class RasterBufferImpl : public RasterBuffer {
24 public: 24 public:
25 RasterBufferImpl(OneCopyTileTaskWorkerPool* worker_pool, 25 RasterBufferImpl(OneCopyTileTaskWorkerPool* worker_pool,
26 ResourceProvider* resource_provider, 26 ResourceProvider* resource_provider,
27 ResourcePool* resource_pool, 27 ResourcePool* resource_pool,
28 ResourceFormat resource_format,
28 const Resource* resource) 29 const Resource* resource)
29 : worker_pool_(worker_pool), 30 : worker_pool_(worker_pool),
30 resource_provider_(resource_provider), 31 resource_provider_(resource_provider),
31 resource_pool_(resource_pool), 32 resource_pool_(resource_pool),
32 resource_(resource), 33 resource_(resource),
33 raster_resource_( 34 raster_resource_(
34 resource_pool->AcquireResource(resource->size(), 35 resource_pool->AcquireResource(resource->size(), resource_format)),
35 resource_pool->default_format())),
36 lock_(new ResourceProvider::ScopedWriteLockGpuMemoryBuffer( 36 lock_(new ResourceProvider::ScopedWriteLockGpuMemoryBuffer(
37 resource_provider_, 37 resource_provider_,
38 raster_resource_->id())), 38 raster_resource_->id())),
39 sequence_(0) {} 39 sequence_(0) {}
40 40
41 ~RasterBufferImpl() override { 41 ~RasterBufferImpl() override {
42 // Release write lock in case a copy was never scheduled. 42 // Release write lock in case a copy was never scheduled.
43 lock_.reset(); 43 lock_.reset();
44 44
45 // Make sure any scheduled copy operations are issued before we release the 45 // Make sure any scheduled copy operations are issued before we release the
(...skipping 52 matching lines...) Expand 10 before | Expand all | Expand 10 after
98 98
99 OneCopyTileTaskWorkerPool::CopyOperation::~CopyOperation() { 99 OneCopyTileTaskWorkerPool::CopyOperation::~CopyOperation() {
100 } 100 }
101 101
102 // static 102 // static
103 scoped_ptr<TileTaskWorkerPool> OneCopyTileTaskWorkerPool::Create( 103 scoped_ptr<TileTaskWorkerPool> OneCopyTileTaskWorkerPool::Create(
104 base::SequencedTaskRunner* task_runner, 104 base::SequencedTaskRunner* task_runner,
105 TaskGraphRunner* task_graph_runner, 105 TaskGraphRunner* task_graph_runner,
106 ContextProvider* context_provider, 106 ContextProvider* context_provider,
107 ResourceProvider* resource_provider, 107 ResourceProvider* resource_provider,
108 ResourcePool* resource_pool) { 108 ResourcePool* resource_pool,
109 ResourceFormat resource_format) {
109 return make_scoped_ptr<TileTaskWorkerPool>(new OneCopyTileTaskWorkerPool( 110 return make_scoped_ptr<TileTaskWorkerPool>(new OneCopyTileTaskWorkerPool(
110 task_runner, task_graph_runner, context_provider, resource_provider, 111 task_runner, task_graph_runner, context_provider, resource_provider,
111 resource_pool)); 112 resource_pool, resource_format));
112 } 113 }
113 114
114 OneCopyTileTaskWorkerPool::OneCopyTileTaskWorkerPool( 115 OneCopyTileTaskWorkerPool::OneCopyTileTaskWorkerPool(
115 base::SequencedTaskRunner* task_runner, 116 base::SequencedTaskRunner* task_runner,
116 TaskGraphRunner* task_graph_runner, 117 TaskGraphRunner* task_graph_runner,
117 ContextProvider* context_provider, 118 ContextProvider* context_provider,
118 ResourceProvider* resource_provider, 119 ResourceProvider* resource_provider,
119 ResourcePool* resource_pool) 120 ResourcePool* resource_pool,
121 ResourceFormat resource_format)
120 : task_runner_(task_runner), 122 : task_runner_(task_runner),
121 task_graph_runner_(task_graph_runner), 123 task_graph_runner_(task_graph_runner),
122 namespace_token_(task_graph_runner->GetNamespaceToken()), 124 namespace_token_(task_graph_runner->GetNamespaceToken()),
123 context_provider_(context_provider), 125 context_provider_(context_provider),
124 resource_provider_(resource_provider), 126 resource_provider_(resource_provider),
125 resource_pool_(resource_pool), 127 resource_pool_(resource_pool),
128 resource_format_(resource_format),
126 last_issued_copy_operation_(0), 129 last_issued_copy_operation_(0),
127 last_flushed_copy_operation_(0), 130 last_flushed_copy_operation_(0),
128 lock_(), 131 lock_(),
129 copy_operation_count_cv_(&lock_), 132 copy_operation_count_cv_(&lock_),
130 scheduled_copy_operation_count_(0), 133 scheduled_copy_operation_count_(0),
131 issued_copy_operation_count_(0), 134 issued_copy_operation_count_(0),
132 next_copy_operation_sequence_(1), 135 next_copy_operation_sequence_(1),
133 check_for_completed_copy_operations_pending_(false), 136 check_for_completed_copy_operations_pending_(false),
134 shutdown_(false), 137 shutdown_(false),
135 weak_ptr_factory_(this), 138 weak_ptr_factory_(this),
(...skipping 108 matching lines...) Expand 10 before | Expand all | Expand 10 after
244 task->CompleteOnOriginThread(this); 247 task->CompleteOnOriginThread(this);
245 task->DidComplete(); 248 task->DidComplete();
246 249
247 task->RunReplyOnOriginThread(); 250 task->RunReplyOnOriginThread();
248 } 251 }
249 completed_tasks_.clear(); 252 completed_tasks_.clear();
250 } 253 }
251 254
252 scoped_ptr<RasterBuffer> OneCopyTileTaskWorkerPool::AcquireBufferForRaster( 255 scoped_ptr<RasterBuffer> OneCopyTileTaskWorkerPool::AcquireBufferForRaster(
253 const Resource* resource) { 256 const Resource* resource) {
254 DCHECK_EQ(resource->format(), resource_pool_->default_format()); 257 DCHECK_EQ(resource->format(), resource_format_);
255 return make_scoped_ptr<RasterBuffer>( 258 return make_scoped_ptr<RasterBuffer>(
256 new RasterBufferImpl(this, resource_provider_, resource_pool_, resource)); 259 new RasterBufferImpl(this, resource_provider_, resource_pool_,
260 resource_format_, resource));
257 } 261 }
258 262
259 void OneCopyTileTaskWorkerPool::ReleaseBufferForRaster( 263 void OneCopyTileTaskWorkerPool::ReleaseBufferForRaster(
260 scoped_ptr<RasterBuffer> buffer) { 264 scoped_ptr<RasterBuffer> buffer) {
261 // Nothing to do here. RasterBufferImpl destructor cleans up after itself. 265 // Nothing to do here. RasterBufferImpl destructor cleans up after itself.
262 } 266 }
263 267
264 CopySequenceNumber 268 CopySequenceNumber
265 OneCopyTileTaskWorkerPool::PlaybackAndScheduleCopyOnWorkerThread( 269 OneCopyTileTaskWorkerPool::PlaybackAndScheduleCopyOnWorkerThread(
266 scoped_ptr<ResourceProvider::ScopedWriteLockGpuMemoryBuffer> write_lock, 270 scoped_ptr<ResourceProvider::ScopedWriteLockGpuMemoryBuffer> write_lock,
(...skipping 217 matching lines...) Expand 10 before | Expand all | Expand 10 after
484 resource_pool_->total_memory_usage_bytes()); 488 resource_pool_->total_memory_usage_bytes());
485 staging_state->SetInteger("pending_copy_count", 489 staging_state->SetInteger("pending_copy_count",
486 resource_pool_->total_resource_count() - 490 resource_pool_->total_resource_count() -
487 resource_pool_->acquired_resource_count()); 491 resource_pool_->acquired_resource_count());
488 staging_state->SetInteger("bytes_pending_copy", 492 staging_state->SetInteger("bytes_pending_copy",
489 resource_pool_->total_memory_usage_bytes() - 493 resource_pool_->total_memory_usage_bytes() -
490 resource_pool_->acquired_memory_usage_bytes()); 494 resource_pool_->acquired_memory_usage_bytes());
491 } 495 }
492 496
493 } // namespace cc 497 } // namespace cc
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698