Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(733)

Issue 860803004: Stop building gm in Android framework build. (Closed)

Created:
5 years, 11 months ago by scroggo
Modified:
5 years, 11 months ago
Reviewers:
bsalomon, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Stop building gm in Android framework build. Allows us to delete gm. Committed: https://skia.googlesource.com/skia/+/c7bfd5b441c0061e4eb787a9ac97448aee58ada5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -13 lines) Patch
M platform_tools/android/bin/gyp_to_android.py View 1 chunk +0 lines, -10 lines 0 comments Download
M platform_tools/android/gyp_gen/makefile_writer.py View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
scroggo
Brian, this will allow you to remove gm completely!
5 years, 11 months ago (2015-01-20 16:14:28 UTC) #2
bsalomon
On 2015/01/20 16:14:28, scroggo wrote: > Brian, this will allow you to remove gm completely! ...
5 years, 11 months ago (2015-01-20 16:17:11 UTC) #3
mtklein
lgtm
5 years, 11 months ago (2015-01-20 16:17:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/860803004/1
5 years, 11 months ago (2015-01-20 16:18:24 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-20 16:25:38 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/c7bfd5b441c0061e4eb787a9ac97448aee58ada5

Powered by Google App Engine
This is Rietveld 408576698