Check that thread contexts are cleaned up during profiling

Check that thread contexts are cleaned up during profiling

There was a Thread Local Store regression, wherein
thread cleanup notifcation was not sent to TLS
users.  This CL ensures that when this happens,
that Chrome will crash.

For now, I'm landed with a short-circuit (returns true
all the time) in the test.  I'll remove the TODO when
we have XP properly supported.

r=rtenneti
BUG=103209
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111451

[jar (doing other things), 2011-11-21 00:07:10]

Raman,

I can't land this yet, as I *think* it will crash when running on XP (due to
lack of TLS cleanup).  Once I get XP fixed, I should be able to land this, and
prevent regressions from going undetected.

I'd like to get this teed up for when the XP support is restored. (I have a
separate CL working on that).

[ramant (doing other things), 2011-11-21 04:14:06]

lgtm

http://codereview.chromium.org/8606001/diff/1004/base/tracked_objects.cc
File base/tracked_objects.cc (right):

http://codereview.chromium.org/8606001/diff/1004/base/tracked_objects.cc#newc...
base/tracked_objects.cc:228: // that the allocator is not longer active on this
thread.
nit: not -> no

http://codereview.chromium.org/8606001/diff/1004/base/tracked_objects.cc#newc...
base/tracked_objects.cc:243: // Only worker threads deed to be retired and
reused.
nit: deed -> need?

http://codereview.chromium.org/8606001/diff/1004/base/tracked_objects.cc#newc...
base/tracked_objects.cc:525: // Verify that we've at least shutdown/cleanup the
major namesd threads, like
nit: unfinished sentence?

http://codereview.chromium.org/8606001/diff/1004/base/tracked_objects.h
File base/tracked_objects.h (right):

http://codereview.chromium.org/8606001/diff/1004/base/tracked_objects.h#newco...
base/tracked_objects.h:603: // list_lock_ is held.
nit: should we consider adjusting comments?

[jar (doing other things), 2011-11-21 17:22:30]

Changes made per comments by rtenneti

http://codereview.chromium.org/8606001/diff/1004/base/tracked_objects.cc
File base/tracked_objects.cc (right):

http://codereview.chromium.org/8606001/diff/1004/base/tracked_objects.cc#newc...
base/tracked_objects.cc:228: // that the allocator is not longer active on this
thread.
On 2011/11/21 04:14:06, ramant wrote:
> nit: not -> no

Done.

http://codereview.chromium.org/8606001/diff/1004/base/tracked_objects.cc#newc...
base/tracked_objects.cc:243: // Only worker threads deed to be retired and
reused.
On 2011/11/21 04:14:06, ramant wrote:
> nit: deed -> need?

Done.

http://codereview.chromium.org/8606001/diff/1004/base/tracked_objects.cc#newc...
base/tracked_objects.cc:525: // Verify that we've at least shutdown/cleanup the
major namesd threads, like
On 2011/11/21 04:14:06, ramant wrote:
> nit: unfinished sentence?

Done.

http://codereview.chromium.org/8606001/diff/1004/base/tracked_objects.h
File base/tracked_objects.h (right):

http://codereview.chromium.org/8606001/diff/1004/base/tracked_objects.h#newco...
base/tracked_objects.h:603: // list_lock_ is held.
On 2011/11/21 04:14:06, ramant wrote:
> nit: should we consider adjusting comments?

Done.

[ramant (doing other things), 2011-11-22 03:59:45]

lgtm

http://codereview.chromium.org/8606001/diff/6001/base/tracked_objects.cc
File base/tracked_objects.cc (right):

http://codereview.chromium.org/8606001/diff/6001/base/tracked_objects.cc#newc...
base/tracked_objects.cc:526: // caller should tell us how many thread shutdowns
should have takes place by
nit: takes -> taken

[jar (doing other things), 2011-11-22 17:15:43]

Change made per comment by rtenneti

http://codereview.chromium.org/8606001/diff/6001/base/tracked_objects.cc
File base/tracked_objects.cc (right):

http://codereview.chromium.org/8606001/diff/6001/base/tracked_objects.cc#newc...
base/tracked_objects.cc:526: // caller should tell us how many thread shutdowns
should have takes place by
On 2011/11/22 03:59:45, ramant wrote:
> nit: takes -> taken

Done.

[jar (doing other things), 2011-11-23 23:51:02]

Small change to disable the test until I get XP working correctly.

[ramant (doing other things), 2011-11-23 23:53:16]

lgtm

[rvargas (doing something else), 2011-11-24 00:09:20]

http://codereview.chromium.org/8606001/diff/17001/base/tracked_objects.cc
File base/tracked_objects.cc (right):

http://codereview.chromium.org/8606001/diff/17001/base/tracked_objects.cc#new...
base/tracked_objects.cc:16: #include "base/win/dllmain.cc"
definitely not cool.