Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 860593003: Move WebInputEvent from public/web to public/platform (Closed)

Created:
5 years, 11 months ago by abarth-chromium
Modified:
5 years, 11 months ago
Reviewers:
eseidel1, eseidel
CC:
mojo-reviews_chromium.org, ojan, esprehn
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Move WebInputEvent from public/web to public/platform Moving WebInputEvent into public/platform lets us refer to it directly in core, which will let us remove the PlatformFooEvent classes. The final pipeline will be: 1) mojo::InputEvent (IPC type, device pixels) 2) blink::WebInputEvent (platform abstraction, logical pixels) 3) blink::Event (DOM type, logical pixels) If mojo::InputEvent used logical pixels, it would probably be easier to just use mojo::InputEvent as the platform abstraction, but instead we use the mojo-to-blink conversion to translate between device and logical pixels, like we do everywhere else in Sky. R=eseidel@google.com, eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/db9953e5ff43d6f47f2ca9a2ed15429820faffba

Patch Set 1 #

Patch Set 2 : Build fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -855 lines) Patch
M sky/engine/platform/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A + sky/engine/platform/exported/WebInputEvent.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/public/BUILD.gn View 4 chunks +2 lines, -2 lines 0 comments Download
A + sky/engine/public/platform/WebInputEvent.h View 2 chunks +7 lines, -8 lines 0 comments Download
A + sky/engine/public/platform/WebTouchPoint.h View 2 chunks +5 lines, -5 lines 0 comments Download
M sky/engine/public/web/WebActiveWheelFlingParameters.h View 1 chunk +1 line, -1 line 0 comments Download
D sky/engine/public/web/WebInputEvent.h View 1 chunk +0 lines, -520 lines 0 comments Download
D sky/engine/public/web/WebTouchPoint.h View 1 chunk +0 lines, -73 lines 0 comments Download
M sky/engine/web/AssertMatchingEnums.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/web/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/web/ChromeClientImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/web/PageWidgetDelegate.cpp View 1 chunk +1 line, -1 line 0 comments Download
D sky/engine/web/WebInputEvent.cpp View 1 chunk +0 lines, -237 lines 0 comments Download
M sky/engine/web/WebInputEventConversion.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/web/WebViewImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/viewer/converters/input_event_types.cc View 1 chunk +1 line, -1 line 0 comments Download
M sky/viewer/document_view.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
abarth-chromium
5 years, 11 months ago (2015-01-20 01:04:10 UTC) #1
eseidel1
lgtm Hopefully you used the move_source_file script and didn't do this by hand. :)
5 years, 11 months ago (2015-01-20 01:59:59 UTC) #3
abarth-chromium
On 2015/01/20 at 01:59:59, eseidel wrote: > lgtm > > Hopefully you used the move_source_file ...
5 years, 11 months ago (2015-01-20 02:39:31 UTC) #4
abarth-chromium
5 years, 11 months ago (2015-01-20 02:39:44 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
db9953e5ff43d6f47f2ca9a2ed15429820faffba (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698