Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 860583002: remove unused SkAvoidXfermode (Closed)

Created:
5 years, 11 months ago by reed2
Modified:
5 years, 11 months ago
Reviewers:
scroggo, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

remove unused SkAvoidXfermode BUG=skia: TBR= NOTRY=True Committed: https://skia.googlesource.com/skia/+/2d02df7a9a50217dac8c1d11681832a927ed79ce

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -371 lines) Patch
M gyp/SampleApp.gyp View 1 1 chunk +0 lines, -1 line 0 comments Download
M gyp/effects.gypi View 1 chunk +0 lines, -1 line 0 comments Download
D include/effects/SkAvoidXfermode.h View 1 chunk +0 lines, -68 lines 0 comments Download
M samplecode/ClockFaceView.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M samplecode/SampleAll.cpp View 2 chunks +0 lines, -13 lines 0 comments Download
D samplecode/SampleAvoid.cpp View 1 chunk +0 lines, -105 lines 0 comments Download
D src/effects/SkAvoidXfermode.cpp View 1 chunk +0 lines, -178 lines 0 comments Download
M src/ports/SkGlobalInitialization_chromium.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M src/ports/SkGlobalInitialization_default.cpp View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 25 (9 generated)
reed2
5 years, 11 months ago (2015-01-18 21:40:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/860583002/1
5 years, 11 months ago (2015-01-18 21:41:11 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 11 months ago (2015-01-18 21:41:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/860583002/20001
5 years, 11 months ago (2015-01-18 21:43:30 UTC) #7
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 11 months ago (2015-01-18 21:43:31 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-VS2013-x86-Debug-Trybot on client.skia.compile (http://build.chromium.org/p/client.skia.compile/builders/Build-Win-VS2013-x86-Debug-Trybot/builds/1945)
5 years, 11 months ago (2015-01-18 21:47:01 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/860583002/20001
5 years, 11 months ago (2015-01-18 21:50:20 UTC) #12
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 11 months ago (2015-01-18 21:50:21 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-VS2013-x86-Debug-Trybot on client.skia.compile (http://build.chromium.org/p/client.skia.compile/builders/Build-Win-VS2013-x86-Debug-Trybot/builds/1947)
5 years, 11 months ago (2015-01-18 21:54:01 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/860583002/20001
5 years, 11 months ago (2015-01-18 22:51:41 UTC) #17
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 11 months ago (2015-01-18 22:51:42 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-VS2013-x86-Debug-Trybot on client.skia.compile (http://build.chromium.org/p/client.skia.compile/builders/Build-Win-VS2013-x86-Debug-Trybot/builds/1949)
5 years, 11 months ago (2015-01-18 22:55:02 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/860583002/20001
5 years, 11 months ago (2015-01-19 04:01:21 UTC) #22
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/2d02df7a9a50217dac8c1d11681832a927ed79ce
5 years, 11 months ago (2015-01-19 04:01:34 UTC) #23
bsalomon
On 2015/01/19 04:01:34, I haz the power (commit-bot) wrote: > Committed patchset #2 (id:20001) as ...
5 years, 11 months ago (2015-01-20 14:27:56 UTC) #24
scroggo
5 years, 11 months ago (2015-01-20 14:32:47 UTC) #25
Message was sent while issue was closed. 
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/822953003/ by scroggo@google.com.

The reason for reverting is: Breaking Android framework build, which still uses
AvoidXfermode. (failure shown here:
https://android-build.storage.googleapis.com/builds/git_master-skia-linux-raz...)

Here is the Java class that uses it:
https://cs.corp.google.com/#android/frameworks/base/graphics/java/android/gra...

It has been deprecated. The glue code (which actually references the Skia file)
is here:
https://cs.corp.google.com/#android/frameworks/base/core/jni/android/graphics...

Mike suggested we move the implementation into Android, which is fine with me..

Powered by Google App Engine
This is Rietveld 408576698