Issue 860483004: Revert "Adding API documentation to the C++ Array and Binding classes."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 860483004: Revert "Adding API documentation to the C++ Array and Binding classes." (Closed)

Created:
5 years, 11 months ago by yzshen1

Modified:
5 years, 11 months ago

Reviewers:
ggowan

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Revert "Adding API documentation to the C++ Array and Binding classes." This reverts commit 0ccff94b79e38095b617db8ebdb18ae1db8708ce. The reason is that I landed this on behalf of ggowan, but I forgot to set the author field correctly. BUG=None TEST=None TBR=ggowan@google.com Committed: https://chromium.googlesource.com/external/mojo/+/42b89a447906b6e3e10b6193e11215f9702213fa

Patch Set 1 #

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -106 lines)			Patch
	M	mojo/public/cpp/bindings/array.h	View		6 chunks	+1 line, -49 lines	0 comments	Download
	M	mojo/public/cpp/bindings/binding.h	View		8 chunks	+3 lines, -57 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

yzshen1

Committed patchset #1 (id:1) manually as 42b89a447906b6e3e10b6193e11215f9702213fa (presubmit successful).

5 years, 11 months ago (2015-01-22 03:08:56 UTC) #1

yzshen1

5 years, 11 months ago (2015-01-22 03:10:50 UTC) #2

Message was sent while issue was closed.

Hi, ggowan.

I noticed that you have gained access to the repo. That is great.

So I reverted this CL. Please land it with your account! :)

Expand Messages | Collapse Messages