Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 86043002: rebaseline_server: remove deprecated-expectations-dir option (Closed)

Created:
7 years ago by epoger
Modified:
7 years ago
Reviewers:
borenet
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

rebaseline_server: remove deprecated-expectations-dir option followup to https://codereview.chromium.org/81243002/ ('rebaseline_server: deprecate --expectations-dir option in advance of git transition') (SkipBuildbotRuns) R=borenet@google.com Committed: https://code.google.com/p/skia/source/detail?r=12381

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -40 lines) Patch
M gm/rebaseline_server/server.py View 9 chunks +14 lines, -40 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
epoger
Please see the updated comments, and let me know if you think my assumptions are ...
7 years ago (2013-11-25 17:11:25 UTC) #1
borenet
Seems right to me. LGTM.
7 years ago (2013-11-25 18:00:45 UTC) #2
epoger
7 years ago (2013-11-25 18:06:30 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r12381 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698