Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1030)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: scripts/master/master_gen.py

Issue 860383008: Made annotated_run look up recipe from builders.pyl masters. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build
Patch Set: Master changes to support this Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« scripts/master/factory/annotator_factory.py ('K') | « scripts/master/factory/annotator_factory.py ('k') | scripts/slave/annotated_run.py » ('j') | scripts/slave/annotated_run.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/master/master_gen.py
diff --git a/scripts/master/master_gen.py b/scripts/master/master_gen.py
index 25e7c75cc69da1c269507fa6fae9f2a52e2c2d4b..be65d9dd516471c391ee58085204ed210eb7c530 100644
--- a/scripts/master/master_gen.py
+++ b/scripts/master/master_gen.py
@@ -64,7 +64,8 @@ def _Populate(BuildmasterConfig, builders, master_cls):
for builder_name, builder_data in builders['builders'].items():
c['builders'].append({
'name': builder_name,
- 'factory': m_annotator.BaseFactory(builder_data['recipe']),
+ # We pass recipe=None so annotated_run finds it at build time.
+ 'factory': m_annotator.BaseFactory(recipe=None),
iannucci 2015/02/03 23:23:18 nuke comment, remove parameter
'slavebuilddir': builder_data['slavebuilddir'],
'slavenames': chromium_utils.GetSlaveNamesForBuilder(builders,
builder_name),
« scripts/master/factory/annotator_factory.py ('K') | « scripts/master/factory/annotator_factory.py ('k') | scripts/slave/annotated_run.py » ('j') | scripts/slave/annotated_run.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698