Made annotated_run look up recipe from builders.pyl masters.

Made annotated_run look up recipe from builders.pyl masters.

BUG=356974
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=293932

[luqui, 2015-02-03 22:06:07]

luqui@chromium.org changed reviewers:
+ iannucci@chromium.org

[luqui, 2015-02-03 22:06:07]

ptal

[iannucci, 2015-02-03 22:29:23]

Wow that was less code than I expected. LGTM.

https://codereview.chromium.org/860383008/diff/1/scripts/slave/annotated_run.py
File scripts/slave/annotated_run.py (right):

https://codereview.chromium.org/860383008/diff/1/scripts/slave/annotated_run....
scripts/slave/annotated_run.py:319: def find_recipe(build_properties):
trick:

  def find_recipe(recipe=None, mastername=None, buildername=None, **_unused):

If you want :)

https://codereview.chromium.org/860383008/diff/1/scripts/slave/annotated_run....
scripts/slave/annotated_run.py:332: builder =
builders['builders'][build_properties['buildername']]
this could raise if ['builders'] doesn't have the buildername. just FYI

https://codereview.chromium.org/860383008/diff/1/scripts/slave/annotated_run....
scripts/slave/annotated_run.py:334: build_properties['recipe'] = recipe
/me flips out

nooooo!!!!! caller should modify build_properties :(

https://codereview.chromium.org/860383008/diff/1/scripts/slave/annotated_run....
scripts/slave/annotated_run.py:335: return recipe
TODO: also return builders['builders'][buildername']['properties'] to .update()
into build_properties?

[luqui, 2015-02-03 23:03:08]

New patchsets have been uploaded after l-g-t-m from iannucci@chromium.org

[luqui, 2015-02-03 23:11:26]

ptal again just to sanity check... I don't want everything in the world to break

[iannucci, 2015-02-03 23:23:18]

lgtm

https://codereview.chromium.org/860383008/diff/40001/scripts/master/factory/a...
File scripts/master/factory/annotator_factory.py (right):

https://codereview.chromium.org/860383008/diff/40001/scripts/master/factory/a...
scripts/master/factory/annotator_factory.py:23: def BaseFactory(self, recipe,
factory_properties=None, triggers=None,
let's make this =None

https://codereview.chromium.org/860383008/diff/40001/scripts/master/master_ge...
File scripts/master/master_gen.py (right):

https://codereview.chromium.org/860383008/diff/40001/scripts/master/master_ge...
scripts/master/master_gen.py:68: 'factory':
m_annotator.BaseFactory(recipe=None),
nuke comment, remove parameter

https://codereview.chromium.org/860383008/diff/40001/scripts/slave/annotated_...
File scripts/slave/annotated_run.py (right):

https://codereview.chromium.org/860383008/diff/40001/scripts/slave/annotated_...
scripts/slave/annotated_run.py:324: already there.
and also merges in properties from builders.pyl

[luqui, 2015-02-04 00:18:20]

New patchsets have been uploaded after l-g-t-m from iannucci@chromium.org

[luqui, 2015-02-04 00:18:53]

The CQ bit was checked by luqui@chromium.org

[commit-bot: I haz the power, 2015-02-04 00:19:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/860383008/60001

[commit-bot: I haz the power, 2015-02-04 00:22:51]

Committed patchset #4 (id:60001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=293932

[Dirk Pranke, 2015-02-04 00:37:00]

On 2015/02/04 00:22:51, I haz the power (commit-bot) wrote:
> Committed patchset #4 (id:60001) as
> http://src.chromium.org/viewvc/chrome?view=rev&revision=293932

nice!