Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 860383007: Move GrXferProcessor subclasses into cpp files (Closed)

Created:
5 years, 10 months ago by egdaniel
Modified:
5 years, 10 months ago
Reviewers:
joshualitt, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@playDstCpy
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Move GrXferProcessor subclasses into cpp files BUG=skia: Committed: https://skia.googlesource.com/skia/+/41d4f09356567ead0216e1a7e4110bd58822b81f

Patch Set 1 #

Patch Set 2 : Rebasing #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+406 lines, -396 lines) Patch
M include/gpu/effects/GrPorterDuffXferProcessor.h View 1 chunk +0 lines, -97 lines 0 comments Download
M src/effects/SkArithmeticMode_gpu.h View 2 chunks +1 line, -65 lines 0 comments Download
M src/effects/SkArithmeticMode_gpu.cpp View 1 5 chunks +82 lines, -12 lines 0 comments Download
M src/gpu/effects/GrCoverageSetOpXP.h View 1 chunk +0 lines, -48 lines 0 comments Download
M src/gpu/effects/GrCoverageSetOpXP.cpp View 3 chunks +67 lines, -19 lines 0 comments Download
M src/gpu/effects/GrCustomXfermode.cpp View 4 chunks +65 lines, -10 lines 0 comments Download
M src/gpu/effects/GrCustomXfermodePriv.h View 2 chunks +1 line, -50 lines 0 comments Download
M src/gpu/effects/GrDisableColorXP.h View 1 chunk +0 lines, -42 lines 0 comments Download
M src/gpu/effects/GrDisableColorXP.cpp View 3 chunks +53 lines, -11 lines 0 comments Download
M src/gpu/effects/GrPorterDuffXferProcessor.cpp View 7 chunks +137 lines, -41 lines 0 comments Download
M src/gpu/gl/GrGLXferProcessor.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
egdaniel
5 years, 10 months ago (2015-02-03 21:13:05 UTC) #2
bsalomon
lgtm
5 years, 10 months ago (2015-02-03 22:12:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/860383007/40001
5 years, 10 months ago (2015-02-09 15:45:43 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-09 15:51:05 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/41d4f09356567ead0216e1a7e4110bd58822b81f

Powered by Google App Engine
This is Rietveld 408576698