Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issue 860383006: Stop using SkAutoTUnref on SkStream. (Closed)

Created:
5 years, 11 months ago by bungeman-chromium
Modified:
5 years, 11 months ago
Reviewers:
scroggo_chromium, eae
CC:
blink-reviews, Dominik Röttsches, krit, Rik, jbroman, danakj, pdr+graphicswatchlist_chromium.org, f(malita), Stephen Chennney, rwlbuis
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Stop using SkAutoTUnref on SkStream. SkStream is no longer reference counted. Discontinue treating it as if it were. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188790

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M Source/platform/fonts/mac/FontCustomPlatformDataMac.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M Source/platform/fonts/skia/FontCustomPlatformDataSkia.cpp View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
bungeman-chromium
This won't actually be able to land until the next Skia roll (which will happen ...
5 years, 11 months ago (2015-01-21 23:45:04 UTC) #2
eae
LGTM
5 years, 11 months ago (2015-01-22 00:08:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/860383006/1
5 years, 11 months ago (2015-01-22 04:00:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/860383006/1
5 years, 11 months ago (2015-01-22 04:22:55 UTC) #8
commit-bot: I haz the power
5 years, 11 months ago (2015-01-22 05:17:38 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188790

Powered by Google App Engine
This is Rietveld 408576698