Remove testfilter support from "git cl"

Remove testfilter support from "git cl"

BUG=432498
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=293743

[Paweł Hajdan Jr., 2015-01-21 14:22:16]

phajdan.jr@chromium.org changed reviewers:
+ maruel@chromium.org

[M-A Ruel, 2015-01-21 14:23:53]

https://codereview.chromium.org/860353003/diff/1/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/860353003/diff/1/git_cl.py#newcode2597
git_cl.py:2597: # Fall back to deprecated method: get try slaves from
PRESUBMIT.py files.
Why not remove this too?

[Paweł Hajdan Jr., 2015-01-21 14:36:18]

https://codereview.chromium.org/860353003/diff/1/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/860353003/diff/1/git_cl.py#newcode2597
git_cl.py:2597: # Fall back to deprecated method: get try slaves from
PRESUBMIT.py files.
On 2015/01/21 14:23:53, M-A Ruel wrote:
> Why not remove this too?

I'm concerned we may have repos which still use it (potentially e.g. nacl or
some other with even smaller teams).

[M-A Ruel, 2015-01-21 14:48:38]

lgtm

https://codereview.chromium.org/860353003/diff/1/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/860353003/diff/1/git_cl.py#newcode2597
git_cl.py:2597: # Fall back to deprecated method: get try slaves from
PRESUBMIT.py files.
On 2015/01/21 14:36:18, Paweł Hajdan Jr. wrote:
> On 2015/01/21 14:23:53, M-A Ruel wrote:
> > Why not remove this too?
> 
> I'm concerned we may have repos which still use it (potentially e.g. nacl or
> some other with even smaller teams).

That's true.

[Paweł Hajdan Jr., 2015-01-22 09:48:12]

The CQ bit was checked by phajdan.jr@chromium.org

[commit-bot: I haz the power, 2015-01-22 09:48:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/860353003/1

[commit-bot: I haz the power, 2015-01-22 09:51:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-22 09:51:39]

Presubmit check for 860353003-1 failed and returned exit status 1.

Running presubmit commit checks ...
Checking out rietveld...
Running save-description-on-failure.sh
Running push-basic.sh
Running upstream.sh
Running submit-from-new-dir.sh
Running abandon.sh
Running submodule-merge-test.sh
Running upload-local-tracking-branch.sh
Running hooks.sh
Running post-dcommit-hook-test.sh
Running upload-stale.sh
Running patch.sh
Running basic.sh

** Presubmit ERRORS **
tests/checkout_test.py (37.49s) failed
Cloning into '/tmp/trialmRcSDR/__main__.GitCheckout.testAll/foo'...
done.
Switched to branch 'master'
Already on 'master'
.ECloning into '/tmp/trialmRcSDR/__main__.GitCheckout.testMove/foo'...
done.
.Cloning into '/tmp/trialmRcSDR/__main__.GitCheckout.testProcess/foo'...
done.
....................
======================================================================
ERROR: testException (__main__.GitCheckout)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/checkout_test.py", line 347, in setUp
    self.enabled = self.FAKE_REPOS.set_up_git()
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/testing_support/fake_repos.py",
line 359, in set_up_git
    self.set_up()
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/testing_support/fake_repos.py",
line 211, in set_up
    self.cleanup_dirt()
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/testing_support/fake_repos.py",
line 229, in cleanup_dirt
    if not self.tear_down_git():
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/testing_support/fake_repos.py",
line 276, in tear_down_git
    wait_for_port_to_free(self.host, self.git_port)
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/testing_support/fake_repos.py",
line 161, in wait_for_port_to_free
    assert False, '%d is still bound' % port
AssertionError: 20000 is still bound

----------------------------------------------------------------------
Ran 23 tests in 37.218s

FAILED (errors=1)


Presubmit checks took 171.1s to calculate.

Was the presubmit check useful? If not, run "git cl presubmit -v"
to figure out which PRESUBMIT.py was run, then run git blame
on the file to figure out who to ask for help.

[Paweł Hajdan Jr., 2015-01-22 10:33:32]

The CQ bit was checked by phajdan.jr@chromium.org

[commit-bot: I haz the power, 2015-01-22 10:34:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/860353003/1

[commit-bot: I haz the power, 2015-01-22 10:37:11]

Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=293743