Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Unified Diff: Source/bindings/templates/methods.cpp

Issue 860353002: IDL: Add toRestricted{Float,Double}() helpers to V8Binding.h (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: add FIXME comment Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/templates/methods.cpp
diff --git a/Source/bindings/templates/methods.cpp b/Source/bindings/templates/methods.cpp
index 4e9bd509da7ae379ba494684f3e6b5bcc1bea06d..5b62e398e8ad8e691c54d73eb67f38505ea21679 100644
--- a/Source/bindings/templates/methods.cpp
+++ b/Source/bindings/templates/methods.cpp
@@ -175,16 +175,7 @@ if (!isUndefinedOrNull(info[{{argument.index}}]) && !info[{{argument.index}}]->I
{% endif %}{# argument.is_nullable #}
{# Type checking, possibly throw a TypeError, per:
http://www.w3.org/TR/WebIDL/#es-type-mapping #}
-{% if argument.has_type_checking_unrestricted %}
-{# Non-finite floating point values (NaN, +Infinity or −Infinity), per:
- http://heycam.github.io/webidl/#es-float
- http://heycam.github.io/webidl/#es-double #}
-if (!std::isfinite({{argument.name}})) {
- {{throw_type_error(method, '"%s parameter %s is non-finite."' %
- (argument.idl_type, argument.index + 1)) | indent}}
- return;
-}
-{% elif argument.has_type_checking_interface and not argument.is_variadic_wrapper_type %}
+{% if argument.has_type_checking_interface and not argument.is_variadic_wrapper_type %}
{# Type checking for wrapper interface types (if interface not implemented,
throw a TypeError), per http://www.w3.org/TR/WebIDL/#es-interface
Note: for variadic arguments, the type checking is done for each matched

Powered by Google App Engine
This is Rietveld 408576698