Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 860173002: Don't use -Wl,-z,defs for msan builds for now. (Closed)

Created:
5 years, 11 months ago by Nico
Modified:
5 years, 11 months ago
Reviewers:
jamesr
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't use -Wl,-z,defs for msan builds for now. Should hopefully unbreak the msan bot: obj/buildtools/third_party/libc++/trunk/src/libc++.bind.o(.ctors.65535+0x0): error: undefined reference to '__msan_init' obj/buildtools/third_party/libc++/trunk/src/libc++.typeinfo.o(.ctors.65535+0x0): error: undefined reference to '__msan_init' BUG=371125 TBR=jamesr@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/b2a7f3a4f17a4975b2fb334d763dab8a81afc7c2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/common.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
Nico
5 years, 11 months ago (2015-01-20 23:36:41 UTC) #2
jamesr
lgtm
5 years, 11 months ago (2015-01-20 23:37:13 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b2a7f3a4f17a4975b2fb334d763dab8a81afc7c2 Cr-Commit-Position: refs/heads/master@{#312298}
5 years, 11 months ago (2015-01-20 23:39:43 UTC) #4
Nico
5 years, 11 months ago (2015-01-20 23:39:52 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b2a7f3a4f17a4975b2fb334d763dab8a81afc7c2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698