Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 860163003: Include X11 headers only when using X11. (Closed)

Created:
5 years, 11 months ago by kalyank
Modified:
5 years, 11 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use X11 headers only when using X11. This was causing problems when building chromium on Linux platforms with no x11 and Ozone enabled. https://codereview.chromium.org/817023005/diff/40001/content/common/BUILD.gn made changes so that we run the version in content_common with a va_stub_header.fragment always. Committed: https://crrev.com/f51c0e9efe38e89b0172be3472bbf0517010642b Cr-Commit-Position: refs/heads/master@{#312563}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M content/common/gpu/media/va_stub_header.fragment View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
kalyank
5 years, 11 months ago (2015-01-21 06:55:30 UTC) #2
kalyank
PTAL
5 years, 11 months ago (2015-01-21 17:49:27 UTC) #3
DaleCurtis
lgtm
5 years, 11 months ago (2015-01-21 19:10:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/860163003/1
5 years, 11 months ago (2015-01-22 04:38:41 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-22 04:49:42 UTC) #7
commit-bot: I haz the power
5 years, 11 months ago (2015-01-22 04:50:29 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f51c0e9efe38e89b0172be3472bbf0517010642b
Cr-Commit-Position: refs/heads/master@{#312563}

Powered by Google App Engine
This is Rietveld 408576698