android: Add CHECK() calls to better understand memory corruption.

android: Add CHECK() calls to better understand memory corruption.

This patch adds two CHECK() calls for each call to
base::android::AttachCurrentThread() and base::android::DetachFromVM(),
in order to better understand the mysterious crashers described in
http://crbug.com/322200

BUG=322200
R=bulach@chromium.org,torne@chromium.org,joth@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=237591

[joth, 2013-11-25 17:08:42]

lgtm

https://codereview.chromium.org/86013003/diff/1/base/android/jni_android.cc
File base/android/jni_android.cc (right):

https://codereview.chromium.org/86013003/diff/1/base/android/jni_android.cc#n...
base/android/jni_android.cc:20: const JNIInvokeInterface* g_jvm_functions =
NULL;
Is the layout of JNIInvokeInterface guaranteed to be consistent across platform
versions?

FWIW I'd put the comment here that this variable, and all usage of it, is for
debugging crbug/xxx

[digit1, 2013-11-25 17:34:02]

https://codereview.chromium.org/86013003/diff/1/base/android/jni_android.cc
File base/android/jni_android.cc (right):

https://codereview.chromium.org/86013003/diff/1/base/android/jni_android.cc#n...
base/android/jni_android.cc:20: const JNIInvokeInterface* g_jvm_functions =
NULL;
Yes, since the structure is defined in <jni.h>, its layout must be stable to
avoid breaking generated machine code.

I'll add some comments though.

[digit1, 2013-11-25 17:35:53]

https://codereview.chromium.org/86013003/diff/1/base/android/jni_android.cc
File base/android/jni_android.cc (right):

https://codereview.chromium.org/86013003/diff/1/base/android/jni_android.cc#n...
base/android/jni_android.cc:20: const JNIInvokeInterface* g_jvm_functions =
NULL;
On 2013/11/25 17:08:42, joth wrote:
> Is the layout of JNIInvokeInterface guaranteed to be consistent across
platform
> versions?
> 
> FWIW I'd put the comment here that this variable, and all usage of it, is for
> debugging crbug/xxx

Done.

[joth, 2013-11-25 17:41:55]

still lgtm

thanks!

[joth, 2013-11-25 17:41:57]

still lgtm

thanks!

[bulach, 2013-11-27 12:22:57]

lgtm, this may have some small perf implications, but worth investigating..
thanks!

[commit-bot: I haz the power, 2013-11-27 13:21:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/digit@chromium.org/86013003/2

[commit-bot: I haz the power, 2013-11-27 17:07:39]

Change committed as 237591