Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 860073002: [ozone] Install ozone message filter in the gpu process in GpuChildThread() (Closed)

Created:
5 years, 11 months ago by alexst (slow to review)
Modified:
5 years, 11 months ago
Reviewers:
piman
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ozone] Install ozone message filter in the gpu process in GpuChildThread() As a follow up to https://codereview.chromium.org/847203004/ we are installing the message filter early enough to be able to process all messages on IO. Currently there is a race condition between filter getting installed and messages arriving and forwarded to main. This installs the filter before the channel is connected preventing the issue. BUG= Committed: https://crrev.com/6154ce77f15a68c83d783ff784ad8a824e2339d4 Cr-Commit-Position: refs/heads/master@{#312319}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -8 lines) Patch
M content/gpu/gpu_child_thread.cc View 2 chunks +19 lines, -8 lines 0 comments Download

Messages

Total messages: 23 (10 generated)
alexst (slow to review)
5 years, 11 months ago (2015-01-20 18:28:11 UTC) #2
piman
lgtm
5 years, 11 months ago (2015-01-20 19:03:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/860073002/1
5 years, 11 months ago (2015-01-20 21:20:21 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/115705) linux_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu_triggered_tests/builds/101592) Try ...
5 years, 11 months ago (2015-01-20 22:41:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/860073002/1
5 years, 11 months ago (2015-01-20 22:50:23 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/115705) linux_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu_triggered_tests/builds/101592) win_chromium_x64_rel_ng ...
5 years, 11 months ago (2015-01-20 22:51:28 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/860073002/1
5 years, 11 months ago (2015-01-20 23:07:43 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/112638) win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/96583) Try ...
5 years, 11 months ago (2015-01-21 02:09:27 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/860073002/1
5 years, 11 months ago (2015-01-21 02:42:41 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/112638) win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/96583)
5 years, 11 months ago (2015-01-21 02:44:21 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/860073002/1
5 years, 11 months ago (2015-01-21 02:46:27 UTC) #21
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-21 12:42:11 UTC) #22
commit-bot: I haz the power
5 years, 11 months ago (2015-01-21 12:46:28 UTC) #23
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6154ce77f15a68c83d783ff784ad8a824e2339d4
Cr-Commit-Position: refs/heads/master@{#312319}

Powered by Google App Engine
This is Rietveld 408576698