Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(865)

Unified Diff: Source/core/svg/SVGURIReference.h

Issue 860063002: Initialize GC mixin bases only when leftmost vtable has been initialized. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: add comments explaining purpose Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/svg/SVGTextPathElement.cpp ('k') | Source/core/svg/SVGURIReference.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/svg/SVGURIReference.h
diff --git a/Source/core/svg/SVGURIReference.h b/Source/core/svg/SVGURIReference.h
index 842162d0cb88b76d248110f53547bf482fab3f5a..26af7ce2683dca08c712a2aa2e39a9624eca2bc1 100644
--- a/Source/core/svg/SVGURIReference.h
+++ b/Source/core/svg/SVGURIReference.h
@@ -58,7 +58,20 @@ public:
virtual void trace(Visitor*);
protected:
- explicit SVGURIReference(SVGElement*);
+ SVGURIReference();
+
+ // FIXME: Oilpan: the construction of this mixin requires heap allocation,
+ // which cannot be safely done with Oilpan until the object that include
+ // this mixin have had its vptr initialized -- so as to be able to
+ // accurately trace the entire object should a GC strike while constructing
+ // the mixin.
+ //
+ // Try to come up with a more natural alternative and solution that doesn't
+ // require hoisting the constructor code for mixins into a separate method
+ // like initialize(). It makes construction of these heap-allocation mixins
+ // safe in the meantime, however.
+ //
+ void initialize(SVGElement*);
private:
RefPtrWillBeMember<SVGAnimatedString> m_href;
« no previous file with comments | « Source/core/svg/SVGTextPathElement.cpp ('k') | Source/core/svg/SVGURIReference.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698