Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Side by Side Diff: Source/core/svg/SVGViewSpec.cpp

Issue 860063002: Initialize GC mixin bases only when leftmost vtable has been initialized. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: add comments explaining purpose Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/svg/SVGViewElement.cpp ('k') | Source/core/svg/animation/SVGSMILElement.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007, 2010 Rob Buis <buis@kde.org> 2 * Copyright (C) 2007, 2010 Rob Buis <buis@kde.org>
3 * 3 *
4 * This library is free software; you can redistribute it and/or 4 * This library is free software; you can redistribute it and/or
5 * modify it under the terms of the GNU Library General Public 5 * modify it under the terms of the GNU Library General Public
6 * License as published by the Free Software Foundation; either 6 * License as published by the Free Software Foundation; either
7 * version 2 of the License, or (at your option) any later version. 7 * version 2 of the License, or (at your option) any later version.
8 * 8 *
9 * This library is distributed in the hope that it will be useful, 9 * This library is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 17 matching lines...) Expand all
28 #include "core/svg/SVGParserUtilities.h" 28 #include "core/svg/SVGParserUtilities.h"
29 29
30 namespace blink { 30 namespace blink {
31 31
32 SVGViewSpec::SVGViewSpec(SVGSVGElement* contextElement) 32 SVGViewSpec::SVGViewSpec(SVGSVGElement* contextElement)
33 // Note: addToPropertyMap is not needed, as SVGViewSpec do not correspond to an element. 33 // Note: addToPropertyMap is not needed, as SVGViewSpec do not correspond to an element.
34 // Note: We make tear-offs' contextElement the target element of SVGViewSpec . 34 // Note: We make tear-offs' contextElement the target element of SVGViewSpec .
35 // This contextElement will be only used for keeping this alive from the tea roff. 35 // This contextElement will be only used for keeping this alive from the tea roff.
36 // SVGSVGElement holds a strong-ref to this SVGViewSpec, so this is kept ali ve as: 36 // SVGSVGElement holds a strong-ref to this SVGViewSpec, so this is kept ali ve as:
37 // AnimatedProperty tearoff -(contextElement)-> SVGSVGElement -(RefPtr)-> SV GViewSpec. 37 // AnimatedProperty tearoff -(contextElement)-> SVGSVGElement -(RefPtr)-> SV GViewSpec.
38 : SVGFitToViewBox(contextElement, PropertyMapPolicySkip) 38 : m_contextElement(contextElement)
39 , m_contextElement(contextElement)
40 , m_transform(SVGAnimatedTransformList::create(contextElement, SVGNames::tra nsformAttr, SVGTransformList::create())) 39 , m_transform(SVGAnimatedTransformList::create(contextElement, SVGNames::tra nsformAttr, SVGTransformList::create()))
41 { 40 {
41 SVGFitToViewBox::initialize(contextElement, PropertyMapPolicySkip);
42
42 ASSERT(m_contextElement); 43 ASSERT(m_contextElement);
43 44
44 viewBox()->setReadOnly(); 45 viewBox()->setReadOnly();
45 preserveAspectRatio()->setReadOnly(); 46 preserveAspectRatio()->setReadOnly();
46 m_transform->setReadOnly(); 47 m_transform->setReadOnly();
47 // Note: addToPropertyMap is not needed, as SVGViewSpec do not correspond to an element. 48 // Note: addToPropertyMap is not needed, as SVGViewSpec do not correspond to an element.
48 } 49 }
49 50
50 void SVGViewSpec::trace(Visitor* visitor) 51 void SVGViewSpec::trace(Visitor* visitor)
51 { 52 {
(...skipping 159 matching lines...) Expand 10 before | Expand all | Expand 10 after
211 ptr++; 212 ptr++;
212 } 213 }
213 214
214 if (ptr >= end || *ptr != ')') 215 if (ptr >= end || *ptr != ')')
215 return false; 216 return false;
216 217
217 return true; 218 return true;
218 } 219 }
219 220
220 } 221 }
OLDNEW
« no previous file with comments | « Source/core/svg/SVGViewElement.cpp ('k') | Source/core/svg/animation/SVGSMILElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698