Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Side by Side Diff: Source/core/svg/SVGTextPathElement.cpp

Issue 860063002: Initialize GC mixin bases only when leftmost vtable has been initialized. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: add comments explaining purpose Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/svg/SVGTests.cpp ('k') | Source/core/svg/SVGURIReference.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007 Nikolas Zimmermann <zimmermann@kde.org> 2 * Copyright (C) 2007 Nikolas Zimmermann <zimmermann@kde.org>
3 * Copyright (C) 2010 Rob Buis <rwlbuis@gmail.com> 3 * Copyright (C) 2010 Rob Buis <rwlbuis@gmail.com>
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
42 DEFINE_STATIC_LOCAL(SVGEnumerationStringEntries, entries, ()); 42 DEFINE_STATIC_LOCAL(SVGEnumerationStringEntries, entries, ());
43 if (entries.isEmpty()) { 43 if (entries.isEmpty()) {
44 entries.append(std::make_pair(SVGTextPathSpacingAuto, "auto")); 44 entries.append(std::make_pair(SVGTextPathSpacingAuto, "auto"));
45 entries.append(std::make_pair(SVGTextPathSpacingExact, "exact")); 45 entries.append(std::make_pair(SVGTextPathSpacingExact, "exact"));
46 } 46 }
47 return entries; 47 return entries;
48 } 48 }
49 49
50 inline SVGTextPathElement::SVGTextPathElement(Document& document) 50 inline SVGTextPathElement::SVGTextPathElement(Document& document)
51 : SVGTextContentElement(SVGNames::textPathTag, document) 51 : SVGTextContentElement(SVGNames::textPathTag, document)
52 , SVGURIReference(this)
53 , m_startOffset(SVGAnimatedLength::create(this, SVGNames::startOffsetAttr, S VGLength::create(LengthModeOther), AllowNegativeLengths)) 52 , m_startOffset(SVGAnimatedLength::create(this, SVGNames::startOffsetAttr, S VGLength::create(LengthModeOther), AllowNegativeLengths))
54 , m_method(SVGAnimatedEnumeration<SVGTextPathMethodType>::create(this, SVGNa mes::methodAttr, SVGTextPathMethodAlign)) 53 , m_method(SVGAnimatedEnumeration<SVGTextPathMethodType>::create(this, SVGNa mes::methodAttr, SVGTextPathMethodAlign))
55 , m_spacing(SVGAnimatedEnumeration<SVGTextPathSpacingType>::create(this, SVG Names::spacingAttr, SVGTextPathSpacingExact)) 54 , m_spacing(SVGAnimatedEnumeration<SVGTextPathSpacingType>::create(this, SVG Names::spacingAttr, SVGTextPathSpacingExact))
56 { 55 {
56 SVGURIReference::initialize(this);
57
57 addToPropertyMap(m_startOffset); 58 addToPropertyMap(m_startOffset);
58 addToPropertyMap(m_method); 59 addToPropertyMap(m_method);
59 addToPropertyMap(m_spacing); 60 addToPropertyMap(m_spacing);
60 } 61 }
61 62
62 DEFINE_NODE_FACTORY(SVGTextPathElement) 63 DEFINE_NODE_FACTORY(SVGTextPathElement)
63 64
64 SVGTextPathElement::~SVGTextPathElement() 65 SVGTextPathElement::~SVGTextPathElement()
65 { 66 {
66 #if !ENABLE(OILPAN) 67 #if !ENABLE(OILPAN)
(...skipping 99 matching lines...) Expand 10 before | Expand all | Expand 10 after
166 clearResourceReferences(); 167 clearResourceReferences();
167 } 168 }
168 169
169 bool SVGTextPathElement::selfHasRelativeLengths() const 170 bool SVGTextPathElement::selfHasRelativeLengths() const
170 { 171 {
171 return m_startOffset->currentValue()->isRelative() 172 return m_startOffset->currentValue()->isRelative()
172 || SVGTextContentElement::selfHasRelativeLengths(); 173 || SVGTextContentElement::selfHasRelativeLengths();
173 } 174 }
174 175
175 } // namespace blink 176 } // namespace blink
OLDNEW
« no previous file with comments | « Source/core/svg/SVGTests.cpp ('k') | Source/core/svg/SVGURIReference.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698