Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Side by Side Diff: Source/core/svg/SVGTests.h

Issue 860063002: Initialize GC mixin bases only when leftmost vtable has been initialized. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: add comments explaining purpose Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/svg/SVGSymbolElement.cpp ('k') | Source/core/svg/SVGTests.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2008 Nikolas Zimmermann <zimmermann@kde.org> 2 * Copyright (C) 2004, 2005, 2008 Nikolas Zimmermann <zimmermann@kde.org>
3 * Copyright (C) 2004, 2005, 2006, 2010 Rob Buis <buis@kde.org> 3 * Copyright (C) 2004, 2005, 2006, 2010 Rob Buis <buis@kde.org>
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
42 bool isValid(Document&) const; 42 bool isValid(Document&) const;
43 43
44 bool parseAttribute(const QualifiedName&, const AtomicString&); 44 bool parseAttribute(const QualifiedName&, const AtomicString&);
45 bool isKnownAttribute(const QualifiedName&); 45 bool isKnownAttribute(const QualifiedName&);
46 46
47 void addSupportedAttributes(HashSet<QualifiedName>&); 47 void addSupportedAttributes(HashSet<QualifiedName>&);
48 48
49 virtual void trace(Visitor*); 49 virtual void trace(Visitor*);
50 50
51 protected: 51 protected:
52 explicit SVGTests(SVGElement* contextElement); 52 SVGTests();
53
54 // FIXME: Oilpan: the construction of this mixin requires heap allocation,
55 // which cannot be safely done with Oilpan until the object that include
56 // this mixin have had its vptr initialized -- so as to be able to
57 // accurately trace the entire object should a GC strike while constructing
58 // the mixin.
59 //
60 // Try to come up with a more natural alternative and solution that doesn't
61 // require hoisting the constructor code for mixins into a separate method
62 // like initialize(). It makes construction of these heap-allocation mixins
63 // safe in the meantime, however.
64 //
65 void initialize(SVGElement*);
53 66
54 private: 67 private:
55 RefPtrWillBeMember<SVGStaticStringList> m_requiredFeatures; 68 RefPtrWillBeMember<SVGStaticStringList> m_requiredFeatures;
56 RefPtrWillBeMember<SVGStaticStringList> m_requiredExtensions; 69 RefPtrWillBeMember<SVGStaticStringList> m_requiredExtensions;
57 RefPtrWillBeMember<SVGStaticStringList> m_systemLanguage; 70 RefPtrWillBeMember<SVGStaticStringList> m_systemLanguage;
58 }; 71 };
59 72
60 } // namespace blink 73 } // namespace blink
61 74
62 #endif // SVGTests_h 75 #endif // SVGTests_h
OLDNEW
« no previous file with comments | « Source/core/svg/SVGSymbolElement.cpp ('k') | Source/core/svg/SVGTests.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698