Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Side by Side Diff: Source/core/svg/SVGTests.cpp

Issue 860063002: Initialize GC mixin bases only when leftmost vtable has been initialized. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2008 Nikolas Zimmermann <zimmermann@kde.org> 2 * Copyright (C) 2004, 2005, 2008 Nikolas Zimmermann <zimmermann@kde.org>
3 * Copyright (C) 2004, 2005, 2006, 2007 Rob Buis <buis@kde.org> 3 * Copyright (C) 2004, 2005, 2006, 2007 Rob Buis <buis@kde.org>
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
(...skipping 12 matching lines...) Expand all
23 #include "core/svg/SVGTests.h" 23 #include "core/svg/SVGTests.h"
24 24
25 #include "core/SVGNames.h" 25 #include "core/SVGNames.h"
26 #include "core/dom/DOMImplementation.h" 26 #include "core/dom/DOMImplementation.h"
27 #include "core/frame/UseCounter.h" 27 #include "core/frame/UseCounter.h"
28 #include "core/svg/SVGElement.h" 28 #include "core/svg/SVGElement.h"
29 #include "platform/Language.h" 29 #include "platform/Language.h"
30 30
31 namespace blink { 31 namespace blink {
32 32
33 SVGTests::SVGTests(SVGElement* contextElement) 33 SVGTests::SVGTests()
34 : m_requiredFeatures(SVGStaticStringList::create(contextElement, SVGNames::r equiredFeaturesAttr))
35 , m_requiredExtensions(SVGStaticStringList::create(contextElement, SVGNames: :requiredExtensionsAttr))
36 , m_systemLanguage(SVGStaticStringList::create(contextElement, SVGNames::sys temLanguageAttr))
37 { 34 {
35 }
36
37 void SVGTests::initialize(SVGElement* contextElement)
38 {
39 ASSERT(!m_requiredFeatures.get());
40 ASSERT(!m_requiredExtensions.get());
41 ASSERT(!m_systemLanguage.get());
haraken 2015/01/20 15:40:32 .get() won't be needed.
sof 2015/01/20 19:02:50 Done, dropped them from the asserts here.
38 ASSERT(contextElement); 42 ASSERT(contextElement);
39 43
44 m_requiredFeatures = SVGStaticStringList::create(contextElement, SVGNames::r equiredFeaturesAttr);
45 m_requiredExtensions = SVGStaticStringList::create(contextElement, SVGNames: :requiredExtensionsAttr);
46 m_systemLanguage = SVGStaticStringList::create(contextElement, SVGNames::sys temLanguageAttr);
47
40 contextElement->addToPropertyMap(m_requiredFeatures); 48 contextElement->addToPropertyMap(m_requiredFeatures);
41 contextElement->addToPropertyMap(m_requiredExtensions); 49 contextElement->addToPropertyMap(m_requiredExtensions);
42 contextElement->addToPropertyMap(m_systemLanguage); 50 contextElement->addToPropertyMap(m_systemLanguage);
43 } 51 }
44 52
45 void SVGTests::trace(Visitor* visitor) 53 void SVGTests::trace(Visitor* visitor)
46 { 54 {
47 visitor->trace(m_requiredFeatures); 55 visitor->trace(m_requiredFeatures);
48 visitor->trace(m_requiredExtensions); 56 visitor->trace(m_requiredExtensions);
49 visitor->trace(m_systemLanguage); 57 visitor->trace(m_systemLanguage);
(...skipping 72 matching lines...) Expand 10 before | Expand all | Expand 10 after
122 } 130 }
123 131
124 void SVGTests::addSupportedAttributes(HashSet<QualifiedName>& supportedAttribute s) 132 void SVGTests::addSupportedAttributes(HashSet<QualifiedName>& supportedAttribute s)
125 { 133 {
126 supportedAttributes.add(SVGNames::requiredFeaturesAttr); 134 supportedAttributes.add(SVGNames::requiredFeaturesAttr);
127 supportedAttributes.add(SVGNames::requiredExtensionsAttr); 135 supportedAttributes.add(SVGNames::requiredExtensionsAttr);
128 supportedAttributes.add(SVGNames::systemLanguageAttr); 136 supportedAttributes.add(SVGNames::systemLanguageAttr);
129 } 137 }
130 138
131 } 139 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698