extensions/common/constants.cc - Issue 859993002: Using "static_assert" in lieu of "COMPILE_ASSERT" in extensions module

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: extensions/common/constants.cc

Issue 859993002: Using "static_assert" in lieu of "COMPILE_ASSERT" in extensions module (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « extensions/browser/warning_set.cc ('k') | extensions/common/permissions/base_set_operators.h » ('j') | no next file with comments »

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "extensions/common/constants.h"	5 #include "extensions/common/constants.h"

6	6

7 namespace extensions {	7 namespace extensions {

8	8

9 const char kExtensionScheme[] = "chrome-extension";	9 const char kExtensionScheme[] = "chrome-extension";

10 const char kExtensionResourceScheme[] = "chrome-extension-resource";	10 const char kExtensionResourceScheme[] = "chrome-extension-resource";

(...skipping 62 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
73 2 * EXTENSION_ICON_SMALL // 64	73 2 * EXTENSION_ICON_SMALL // 64

74 };	74 };

75	75

76 const size_t kNumExtensionIconSizes = arraysize(kExtensionIconSizes);	76 const size_t kNumExtensionIconSizes = arraysize(kExtensionIconSizes);

77	77

78 const IconRepresentationInfo kExtensionActionIconSizes[] = {	78 const IconRepresentationInfo kExtensionActionIconSizes[] = {

79 { EXTENSION_ICON_ACTION, "19", ui::SCALE_FACTOR_100P },	79 { EXTENSION_ICON_ACTION, "19", ui::SCALE_FACTOR_100P },

80 { 2 * EXTENSION_ICON_ACTION, "38", ui::SCALE_FACTOR_200P }	80 { 2 * EXTENSION_ICON_ACTION, "38", ui::SCALE_FACTOR_200P }

81 };	81 };

82	82

83 COMPILE_ASSERT(kNumExtensionActionIconSizes ==	83 static_assert(kNumExtensionActionIconSizes ==

84 arraysize(kExtensionActionIconSizes),	84 arraysize(kExtensionActionIconSizes),

85 num_action_icon_sizes_must_be_in_sync_with_action_icon_sizes);	85 "num action icon sizes must be in sync with action icon sizes");

86	86

87 } // namespace extension_misc	87 } // namespace extension_misc

OLD	NEW