Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 859963003: Remove roll_deps and trybots_to_run (Closed)

Created:
5 years, 11 months ago by rmistry
Modified:
5 years, 11 months ago
Reviewers:
*borenet
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove roll_deps and trybots_to_run. BUG=skia: Committed: https://skia.googlesource.com/skia/+/6a93900f064858770faaa79b27aacaf38887359d

Patch Set 1 : Remove roll_deps and trybots_to_run #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -307 lines) Patch
M tools/roll_deps.py View 1 chunk +0 lines, -297 lines 0 comments Download
D trybots_to_run/chrome/README.txt View 1 chunk +0 lines, -8 lines 0 comments Download
M trybots_to_run/chrome/depsroll View 1 chunk +0 lines, -1 line 0 comments Download
M trybots_to_run/chrome/layout View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
rmistry
5 years, 11 months ago (2015-01-20 13:03:11 UTC) #3
borenet
Let's remove these files instead.
5 years, 11 months ago (2015-01-20 13:10:34 UTC) #4
rmistry
On 2015/01/20 13:10:34, borenet wrote: > Let's remove these files instead. Done.
5 years, 11 months ago (2015-01-20 13:35:43 UTC) #5
borenet
On 2015/01/20 13:35:43, rmistry wrote: > On 2015/01/20 13:10:34, borenet wrote: > > Let's remove ...
5 years, 11 months ago (2015-01-20 13:36:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/859963003/20001
5 years, 11 months ago (2015-01-20 13:37:43 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/6a93900f064858770faaa79b27aacaf38887359d
5 years, 11 months ago (2015-01-20 13:44:49 UTC) #9
rmistry
5 years, 11 months ago (2015-01-20 13:46:36 UTC) #11
Message was sent while issue was closed. 
On 2015/01/20 13:36:58, borenet wrote:
> On 2015/01/20 13:35:43, rmistry wrote:
> > On 2015/01/20 13:10:34, borenet wrote:
> > > Let's remove these files instead.
> > 
> > Done.
> 
> LGTM. Not sure why Rietveld shows "M" instead of "D" for these files though.

Yea, I think its a known issue. Rietveld fallsback on "M" when it gets confused.

Powered by Google App Engine
This is Rietveld 408576698