LayoutTests/fast/dom/shadow/spellcheck-attribute-inherit.html - Issue 859943002: Use the composed tree for the title attributes in Shadow DOM

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/dom/shadow/spellcheck-attribute-inherit.html

Issue 859943002: Use the composed tree for the title attributes in Shadow DOM (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« LayoutTests/fast/dom/shadow/lang-attribute-inherit.html ('K') | « LayoutTests/fast/dom/shadow/lang-attribute-inherit.html ('k') | LayoutTests/fast/dom/shadow/title-attribute-inherit.html » ('j') | Source/core/dom/Element.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../../../resources/testharness.js"></script>

	3 <script src="../../../resources/testharnessreport.js"></script>

	4 <div id="container" spellcheck="false" lang="en-us">

	5 <div id="host"><div id="editable" contenteditable></div></div>

	6 </div>

	7 <script>

	8 if (window.internals) {

	9 internals.settings.setUnifiedTextCheckerEnabled(true);

	10 internals.settings.setAsynchronousSpellCheckingEnabled(false);

	11 internals.setContinuousSpellCheckingEnabled(true);

	12 }

	13 var host = document.getElementById("host");

	14 var root = host.createShadowRoot();

	15 root.innerHTML = "<div spellcheck=true><content></content></div>";

	16 var editable = document.getElementById("editable");

	17 editable.innerText = "zz zz zz.";

	18 editable.focus();

	19 if (window.internals) {

	20 test(function () {
	hayato 2015/01/21 09:04:50 I guess this is checking whether 'spelling' is ena I guess this is checking whether 'spelling' is enabled or not for the editable element. Could you extract this check logic as a separate function and name it explicitly? e.g. function isSpellingEnabled(element) { ... } That would make the intention more clear. kojii 2015/01/21 16:46:20 Done. Show quoted text On 2015/01/21 09:04:50, hayato wrote: > I guess this is checking whether 'spelling' is enabled or not for the editable > element. > Could you extract this check logic as a separate function and name it > explicitly? > > e.g. > function isSpellingEnabled(element) { > ... > } > > That would make the intention more clear. Done.
	21 assert_equals(internals.markerCountForNode(editable.firstChild, "spellin g"), 3);

	22 }, "spellcheck tarverses composed tree");

	23 container.style.display = "none";

	24 }

	25 </script>

OLD	NEW