Compare non-whitelisted off-domain inclusions against the browsing history.

tools/metrics/histograms/histograms.xml

Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 7964d1431c3354ab667643c8036a2c8b3bcfdfcd..a465a744da55cbd2c04f88c1336d12e39abf231f 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -31426,6 +31426,57 @@ Therefore, the affected-histogram name has to have at least one dot in it.
   </summary>
 </histogram>
 
+<histogram name="SBOffDomainInclusion.AbortEmptyMainFrameURL"

[Alexei Svitkine (slow), 2015/01/20 17:48:13]

Have you considered naming these so the grouping is more obvious?

e.g. SBOffDomainInclusion.Aborted.EmptyMainFrameURL

and so forth...

Then, you can use a histogram_suffixes construct here to avoid the redundancy in
the XML file.

[gab, 2015/01/20 18:10:48]

How's redundancy reduced? They still all mean different things, would the
suffixes not have a description? Wouldn't that reduce the information?

This doesn't feel like a natural case for suffixes as the enum in the product
code would then be split across two histograms group which would be somewhat
weird.

[Alexei Svitkine (slow), 2015/01/20 18:17:48]

I believe each suffix can have a description that will be appended to the
histogram's description.
Sorry, I don't understand what you mean. All of these .Abort* histograms are
using the same enum - ContentResourceType...

histogram_suffixes just makes the XML in this file a bit more concise. Also, the
naming convention I propose (regardless of the use of histogram_suffixes)
provides better grouping on the dashboard (e.g. you can do .* to get all of the
reasons together.)

[gab, 2015/01/20 18:51:57]

What I was trying to say is that it feels weird that some AnalysisEvent would
result in a suffixed histogram and others in a regular histogram.

I tried something, let me know if you prefer that. I like the conciseness of the
histograms.xml change now, but don't like the split of some histograms being
declared up top and some other in the suffix for the same enum. Some pluses some
minuses, so I don't really mind one way or another.

+    enum="ContentResourceType">
+  <owner>gab@chromium.org</owner>
+  <summary>
+    Logs the resource type of each resource request for which the off-domain
+    inclusion analysis was aborted because the main frame URL was empty.
+  </summary>
+</histogram>
+
+<histogram name="SBOffDomainInclusion.AbortHistoryLookupFailed"
+    enum="ContentResourceType">
+  <owner>gab@chromium.org</owner>
+  <summary>
+    Logs the resource type of each resource request for which the off-domain
+    inclusion analysis was aborted because the lookup to the HistoryService
+    failed unexpectingly.
+  </summary>
+</histogram>
+
+<histogram name="SBOffDomainInclusion.AbortIncognito"
+    enum="ContentResourceType">
+  <owner>gab@chromium.org</owner>
+  <summary>
+    Logs the resource type of each resource request for which the off-domain
+    inclusion analysis was aborted because the profile associated with the frame
+    under analysis is an incognito profile.
+  </summary>
+</histogram>
+
+<histogram name="SBOffDomainInclusion.AbortNoHistoryService"
+    enum="ContentResourceType">
+  <owner>gab@chromium.org</owner>
+  <summary>
+    Logs the resource type of each resource request for which the off-domain
+    inclusion analysis was aborted because there was no HistoryService
+    associated with the profile of the frame under analysis. This can happen
+    seldomly on startup for early net requests but shouldn't be common.
+  </summary>
+</histogram>
+
+<histogram name="SBOffDomainInclusion.AbortNoProfile"
+    enum="ContentResourceType">
+  <owner>gab@chromium.org</owner>
+  <summary>
+    Logs the resource type of each resource request for which the off-domain
+    inclusion analysis was aborted because the profile associated with the frame
+    under analysis couldn't be resolved (expected to happen at a low frequency
+    by the asynchronous nature of the analysis).
+  </summary>
+</histogram>
+
 <histogram name="SBOffDomainInclusion.Detected" enum="ContentResourceType">
   <obsolete>
     Deprecated 01/2015.
@@ -31439,6 +31490,9 @@ Therefore, the affected-histogram name has to have at least one dot in it.
 
 <histogram name="SBOffDomainInclusion.EmptyMainFrameURL"
     enum="ContentResourceType">
+  <obsolete>
+    Deprecated 01/2015.
+  </obsolete>
   <owner>gab@chromium.org</owner>
   <summary>
     Logs the resource type of each resource request for which the main frame URL
@@ -31446,8 +31500,21 @@ Therefore, the affected-histogram name has to have at least one dot in it.
   </summary>
 </histogram>
 
+<histogram name="SBOffDomainInclusion.InHistory" enum="ContentResourceType">
+  <owner>gab@chromium.org</owner>
+  <summary>
+    Logs the resource type of each resource request for which the off-domain
+    inclusion analysis concluded in no inclusion whitelist hit but a browsing
+    history hit.
+  </summary>
+</histogram>
+
 <histogram name="SBOffDomainInclusion.InvalidMainFrameURL"
     enum="ContentResourceType">
+  <obsolete>
+    Deprecated 01/2015 (was never reported, confirming experiment that handling
+    it is irrelevant).
+  </obsolete>
   <owner>gab@chromium.org</owner>
   <summary>
     Logs the resource type of each resource request for which the main frame URL
@@ -31476,9 +31543,8 @@ Therefore, the affected-histogram name has to have at least one dot in it.
 <histogram name="SBOffDomainInclusion.Whitelisted" enum="ContentResourceType">
   <owner>gab@chromium.org</owner>
   <summary>
-    Logs the resource type of each resource request for which an off-domain
-    inclusion was detected by the OffDomainInclusionDetector and ignored because
-    it was present on the inclusion whitelist.
+    Logs the resource type of each resource request for which the off-domain
+    inclusion analysis concluded in an inclusion whitelist hit.
   </summary>
 </histogram>