Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 859903002: Compare non-whitelisted off-domain inclusions against the browsing history. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@#c3_ODID_async
Patch Set: merge r312228 Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 7964d1431c3354ab667643c8036a2c8b3bcfdfcd..0d923f8bd7ee932cec0989aeac96ab01d2309f73 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -31426,6 +31426,15 @@ Therefore, the affected-histogram name has to have at least one dot in it.
</summary>
</histogram>
+<histogram name="SBOffDomainInclusion.Abort" enum="ContentResourceType">
+ <owner>gab@chromium.org</owner>
+ <summary>
+ Logs the resource type of each resource request for which the off-domain
+ inclusion analysis was aborted. This histogram is suffixed with the abort
+ reason.
+ </summary>
+</histogram>
+
<histogram name="SBOffDomainInclusion.Detected" enum="ContentResourceType">
<obsolete>
Deprecated 01/2015.
@@ -31439,6 +31448,9 @@ Therefore, the affected-histogram name has to have at least one dot in it.
<histogram name="SBOffDomainInclusion.EmptyMainFrameURL"
enum="ContentResourceType">
+ <obsolete>
+ Deprecated 01/2015.
grt (UTC plus 2) 2015/01/21 02:04:42 can a comment here somehow direct readers of the c
gab 2015/01/23 21:35:33 Done.
+ </obsolete>
<owner>gab@chromium.org</owner>
<summary>
Logs the resource type of each resource request for which the main frame URL
@@ -31446,8 +31458,21 @@ Therefore, the affected-histogram name has to have at least one dot in it.
</summary>
</histogram>
+<histogram name="SBOffDomainInclusion.InHistory" enum="ContentResourceType">
+ <owner>gab@chromium.org</owner>
+ <summary>
+ Logs the resource type of each resource request for which the off-domain
+ inclusion analysis concluded in no inclusion whitelist hit but a browsing
+ history hit.
+ </summary>
+</histogram>
+
<histogram name="SBOffDomainInclusion.InvalidMainFrameURL"
enum="ContentResourceType">
+ <obsolete>
+ Deprecated 01/2015 (was never reported, confirming experiment that handling
+ it is irrelevant).
+ </obsolete>
<owner>gab@chromium.org</owner>
<summary>
Logs the resource type of each resource request for which the main frame URL
@@ -31476,9 +31501,8 @@ Therefore, the affected-histogram name has to have at least one dot in it.
<histogram name="SBOffDomainInclusion.Whitelisted" enum="ContentResourceType">
<owner>gab@chromium.org</owner>
<summary>
- Logs the resource type of each resource request for which an off-domain
- inclusion was detected by the OffDomainInclusionDetector and ignored because
- it was present on the inclusion whitelist.
+ Logs the resource type of each resource request for which the off-domain
+ inclusion analysis concluded in an inclusion whitelist hit.
</summary>
</histogram>
@@ -61480,6 +61504,25 @@ To add a new entry, add it with any value and run test to compute valid value.
<affected-histogram name="NewTabPage.SuggestionsImpression"/>
</histogram_suffixes>
+<histogram_suffixes name="OffDomainInclusionAbortReason" separator=".">
+ <suffix name="EmptyMainFrameURL" label="The main frame URL was empty."/>
+ <suffix name="HistoryLookupFailed"
+ label="The lookup to the HistoryService failed."/>
+ <suffix name="Incognito"
+ label="The profile associated with the frame under analysis is an
+ incognito profile."/>
+ <suffix name="NoHistoryService"
+ label="There was no HistoryService associated with the profile of the
+ frame under analysis (this can happen seldomly on startup for
+ early net requests, or on shutdown by the asynchronous nature of
+ the analysis, but shouldn't be common)."/>
+ <suffix name="NoProfile"
+ label="The profile associated with the frame under analysis couldn't be
+ resolved (expected to happen at a low frequency by the
+ asynchronous nature of the analysis)."/>
+ <affected-histogram name="SBOffDomainInclusion.Abort"/>
+</histogram_suffixes>
+
<histogram_suffixes name="OmniboxProviderTime" separator=".">
<suffix name="Bookmark"/>
<suffix name="Builtin"/>

Powered by Google App Engine
This is Rietveld 408576698