Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Unified Diff: tools/cygprofile/patch_orderfile.py

Issue 859873002: Fix the prefix removal in patch_orderfile.py. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/cygprofile/patch_orderfile.py
diff --git a/tools/cygprofile/patch_orderfile.py b/tools/cygprofile/patch_orderfile.py
index 65c6d8fb177a99176313027b3c3abfdd1d783249..ddba312c3d46ace55b4c72b00b90bd36e92fa74e 100755
--- a/tools/cygprofile/patch_orderfile.py
+++ b/tools/cygprofile/patch_orderfile.py
@@ -63,7 +63,7 @@ def binary_search (search_addr, start, end):
f = open (orderfile)
lines = f.readlines()
profiled_list = []
-prefixes = ['.text.', '.text.startup.', '.text.hot.', '.text.unlikely.']
+prefixes = ['.text.startup.', '.text.hot.', '.text.unlikely.', '.text.']
for line in lines:
for prefix in prefixes:
line = line.replace(prefix, '')
@@ -100,7 +100,7 @@ for function in profiled_list:
symbols_found = symbols_found + 1
except Exception:
addrs = []
- # sys.stderr.write ("WARNING: could not find symbol " + function + "\n")
+ sys.stderr.write ("WARNING: could not find symbol " + function + "\n")
azarchs 2015/01/19 18:13:21 From my local run I'd expect roughly 140k warnings
for addr in addrs:
if not (addr in addresses):
addresses.append(addr)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698