Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(595)

Issue 859873002: Fix the prefix removal in patch_orderfile.py. (Closed)

Created:
5 years, 11 months ago by Benoit L
Modified:
5 years, 11 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix the prefix removal in patch_orderfile.py. Committed: https://crrev.com/aeccd0f8b22c8af534cb68d3c4734575b0ca89fb Cr-Commit-Position: refs/heads/master@{#312137}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Limit the number of warnings displayed. #

Total comments: 1

Patch Set 3 : Address pasko's comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M tools/cygprofile/patch_orderfile.py View 1 2 2 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
Benoit L
5 years, 11 months ago (2015-01-19 18:11:10 UTC) #2
azarchs
https://codereview.chromium.org/859873002/diff/1/tools/cygprofile/patch_orderfile.py File tools/cygprofile/patch_orderfile.py (right): https://codereview.chromium.org/859873002/diff/1/tools/cygprofile/patch_orderfile.py#newcode103 tools/cygprofile/patch_orderfile.py:103: sys.stderr.write ("WARNING: could not find symbol " + function ...
5 years, 11 months ago (2015-01-19 18:13:22 UTC) #3
azarchs
lgtm
5 years, 11 months ago (2015-01-19 18:27:22 UTC) #4
pasko-google - do not use
lgtm with one optional enhancement https://codereview.chromium.org/859873002/diff/20001/tools/cygprofile/patch_orderfile.py File tools/cygprofile/patch_orderfile.py (right): https://codereview.chromium.org/859873002/diff/20001/tools/cygprofile/patch_orderfile.py#newcode110 tools/cygprofile/patch_orderfile.py:110: sys.stderr.write ("symbols found: " ...
5 years, 11 months ago (2015-01-19 18:36:50 UTC) #6
pasko
now lgtm from the right account (but the suggestion holds:)
5 years, 11 months ago (2015-01-19 18:39:42 UTC) #7
Benoit L
On 2015/01/19 18:39:42, pasko wrote: > now lgtm from the right account (but the suggestion ...
5 years, 11 months ago (2015-01-19 18:41:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/859873002/40001
5 years, 11 months ago (2015-01-19 18:42:26 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 11 months ago (2015-01-19 19:32:25 UTC) #11
commit-bot: I haz the power
5 years, 11 months ago (2015-01-19 19:33:17 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/aeccd0f8b22c8af534cb68d3c4734575b0ca89fb
Cr-Commit-Position: refs/heads/master@{#312137}

Powered by Google App Engine
This is Rietveld 408576698