Issue 859863002: Fix shell URL resolver.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 859863002: Fix shell URL resolver. (Closed)

Created:
5 years, 11 months ago by qsr

Modified:
5 years, 11 months ago

Reviewers:
Aaron Boodman

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Fix shell URL resolver. Fix the resolver so that if we map mojo:a to mojo:b and mojo:b is handled by a custom loader, then the loader for mojo:b is invoked. R=aa@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/75aef1df890f32e01563ed5f05158ea2700c5e67

Patch Set 1 #

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+43 lines, -6 lines)			Patch
M	shell/application_manager/application_manager.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	shell/application_manager/application_manager.cc	View	2 chunks	+9 lines, -4 lines	0 comments	Download
M	shell/application_manager/application_manager_unittest.cc	View	2 chunks	+27 lines, -1 line	0 comments	Download
M	shell/context.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	shell/context.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	shell/mojo_url_resolver.h	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

qsr

5 years, 11 months ago (2015-01-21 11:04:43 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
75aef1df890f32e01563ed5f05158ea2700c5e67 (presubmit successful).

Expand Messages | Collapse Messages