Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2150)

Issue 859773002: Unobscurified OFStream. (Closed)

Created:
5 years, 11 months ago by Sven Panne
Modified:
5 years, 11 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Unobscurified OFStream. Use simple HAS-A relationship instead of obscure multiple inheritance. In theory, UBSan should be totally happy with this, but it still isn't. This seems to be a bug in UBSan, see e.g. http://lists.cs.uiuc.edu/pipermail/cfe-dev/2014-December/040225.html BUG=chromium:448102 LOG=y Committed: https://crrev.com/327d4a7cde4bf16148b16c71ef467938027c2b49 Cr-Commit-Position: refs/heads/master@{#26139}

Patch Set 1 #

Patch Set 2 : Undo accidental commit. #

Patch Set 3 : Make MSVC happy. #

Patch Set 4 : Yet another static_cast for MSVC... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -10 lines) Patch
M src/ostreams.h View 1 chunk +8 lines, -8 lines 0 comments Download
M src/ostreams.cc View 1 2 3 2 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
Sven Panne
5 years, 11 months ago (2015-01-19 12:24:38 UTC) #2
Benedikt Meurer
lgtm
5 years, 11 months ago (2015-01-19 12:25:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/859773002/20001
5 years, 11 months ago (2015-01-19 12:26:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/859773002/40001
5 years, 11 months ago (2015-01-19 12:49:26 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: v8_win_rel on tryserver.v8 (http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel/builds/2376)
5 years, 11 months ago (2015-01-19 13:54:28 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/859773002/60001
5 years, 11 months ago (2015-01-19 14:14:56 UTC) #11
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 11 months ago (2015-01-19 14:41:43 UTC) #12
commit-bot: I haz the power
5 years, 11 months ago (2015-01-19 14:41:55 UTC) #13
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/327d4a7cde4bf16148b16c71ef467938027c2b49
Cr-Commit-Position: refs/heads/master@{#26139}

Powered by Google App Engine
This is Rietveld 408576698