Issue 8597010: Send fake event when event_type is set to exit menu

Issue 8597010: Send fake event when event_type is set to exit menu (Closed)

Created:
9 years, 1 month ago by oshima

Modified:
9 years, 1 month ago

Reviewers:
sadrul, sky

CC:
chromium-reviews, sadrul, yusukes+watch_chromium.org, derat+watch_chromium.org, tfarina, brettw-cc_chromium.org, dhollowa

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Send fake event when event_type is set to exit menu so that nested loop can exit. BUG=104684 TEST=BrowserTest.CloseWithAppMenuOpen passes on aura build Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110774

Patch Set 1 #

Patch Set 2 : git-try #

Patch Set 3 : " #

Patch Set 4 : win fix #

Total comments: 1

Patch Set 5 : addressed comment #

Total comments: 1

Patch Set 6 : use xdisplay_ #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+74 lines, -16 lines)			Patch
M	ui/aura/desktop.h	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	ui/aura/desktop.cc	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	ui/aura/desktop_host.h	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	ui/aura/desktop_host_linux.cc	View	1 2 3 4 5	2 chunks	+10 lines, -0 lines	0 comments	Download
M	ui/aura/desktop_host_win.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	ui/aura/desktop_host_win.cc	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	ui/base/events.h	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	ui/base/win/events_win.cc	View	1	1 chunk	+8 lines, -0 lines	0 comments	Download
M	ui/base/x/events_x.cc	View	1	2 chunks	+11 lines, -0 lines	0 comments	Download
M	views/controls/menu/menu_controller.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	views/controls/menu/menu_controller.cc	View	1 2 3 4	10 chunks	+23 lines, -16 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

sky

LGTM http://codereview.chromium.org/8597010/diff/10/views/controls/menu/menu_controller.cc File views/controls/menu/menu_controller.cc (right): http://codereview.chromium.org/8597010/diff/10/views/controls/menu/menu_controller.cc#newcode1965 views/controls/menu/menu_controller.cc:1965: if (exit_type_ == EXIT_ALL || exit_type_ == EXIT_DESTROYED) ...

9 years, 1 month ago (2011-11-18 21:12:22 UTC) #2

oshima

On 2011/11/18 21:12:22, sky wrote: > LGTM > > http://codereview.chromium.org/8597010/diff/10/views/controls/menu/menu_controller.cc > File views/controls/menu/menu_controller.cc (right): > ...

9 years, 1 month ago (2011-11-18 21:44:22 UTC) #3

sadrul

http://codereview.chromium.org/8597010/diff/10002/ui/aura/desktop_host_linux.cc File ui/aura/desktop_host_linux.cc (right): http://codereview.chromium.org/8597010/diff/10002/ui/aura/desktop_host_linux.cc#newcode487 ui/aura/desktop_host_linux.cc:487: Display* xdisplay = base::MessagePumpX::GetDefaultXDisplay(); Is there a reason to ...

9 years, 1 month ago (2011-11-18 21:46:54 UTC) #4

oshima

9 years, 1 month ago (2011-11-18 21:49:01 UTC) #5

On 2011/11/18 21:46:54, sadrul wrote:
>
http://codereview.chromium.org/8597010/diff/10002/ui/aura/desktop_host_linux.cc
> File ui/aura/desktop_host_linux.cc (right):
> 
>
http://codereview.chromium.org/8597010/diff/10002/ui/aura/desktop_host_linux....
> ui/aura/desktop_host_linux.cc:487: Display* xdisplay =
> base::MessagePumpX::GetDefaultXDisplay();
> Is there a reason to not use xdisplay_?

Because i'm stupid! Done. (Thanks :)

Expand Messages | Collapse Messages