Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 859683004: Forward --no-sandbox flag, if present, to LoadAndLaunch platform app tests. (Closed)

Created:
5 years, 11 months ago by benwells
Modified:
5 years, 11 months ago
Reviewers:
jackhou1
CC:
chromium-reviews, tfarina, chromium-apps-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Forward --no-sandbox flag, if present, to LoadAndLaunch platform app tests. This flag was being discarded if it was set on the command line, causing problems for ASAN tests on windows. BUG=449588 Committed: https://crrev.com/fa1651193bf94120b61abb1a7f987ded6556caeb Cr-Commit-Position: refs/heads/master@{#312161}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -10 lines) Patch
M apps/load_and_launch_browsertest.cc View 4 chunks +14 lines, -10 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
benwells
5 years, 11 months ago (2015-01-19 23:32:14 UTC) #2
jackhou1
lgtm
5 years, 11 months ago (2015-01-20 04:07:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/859683004/1
5 years, 11 months ago (2015-01-20 04:09:30 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-20 04:13:19 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-20 04:14:26 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fa1651193bf94120b61abb1a7f987ded6556caeb
Cr-Commit-Position: refs/heads/master@{#312161}

Powered by Google App Engine
This is Rietveld 408576698