GetEffectiveDomain should handle ws scheme as same as http scheme.

net/cookies/cookie_monster_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/cookies/cookie_store_unittest.h"
 
 #include <algorithm>
 #include <string>
 #include <vector>
 
@@ skipping 2593 matching lines @@
   it = cookies.begin();
   base::Closure task = base::Bind(
       &net::MultiThreadedCookieMonsterTest::DeleteCanonicalCookieTask,
       base::Unretained(this),
       cm, *it, &callback);
   RunOnOtherThread(task);
   EXPECT_TRUE(callback.did_run());
   EXPECT_TRUE(callback.result());
 }
 
+// Ensure that cookies for http, https, ws, and wss all share the same storage
+// and policies, when GetAllCookiesForURLAsync is used. This test is located

[Ryan Sleevi, 2015/01/26 19:49:54]

grammar nit: no comma between policies and when.

[yhirano, 2015/01/27 02:07:10]

Done.

+// on MultiThreadedCookieMonsterTest in order to call GetAllCookiesForURLAsync
+// asynchronously, but doesn't use a separate thread in spite of the name.

[Ryan Sleevi, 2015/01/26 19:49:54]

grammar nit: I found this second sentence a bit confusing. Perhaps reworded as:

This test is part of MultiThreadedCookieMonsterTest in order to test and use
GetAllCookiesForURLAsync, but it does not use any additional threads.

[yhirano, 2015/01/27 02:07:10]

Done.

+TEST_F(MultiThreadedCookieMonsterTest, GetAllCookiesForURLEffectiveDomain) {
+  std::vector<CanonicalCookie*> cookies;
+  // This cookie will be freed by the CookieMonster.
+  cookies.push_back(CanonicalCookie::Create(url_google_, kValidCookieLine,
+                                            Time::Now(), CookieOptions()));
+  CanonicalCookie cookie = *cookies[0];
+  scoped_refptr<NewMockPersistentCookieStore> store(
+      new NewMockPersistentCookieStore);
+  scoped_refptr<CookieMonster> cm(new CookieMonster(store.get(), NULL));
+
+  CookieMonster::PersistentCookieStore::LoadedCallback loaded_callback;
+  ::testing::StrictMock<::testing::MockFunction<void(int)>> checkpoint;
+  const std::string key =
+      cookie_util::GetEffectiveDomain(url_google_.scheme(), url_google_.host());
+
+  {
+    ::testing::InSequence s;
+    EXPECT_CALL(checkpoint, Call(0));
+    EXPECT_CALL(*store, Load(::testing::_));
+    EXPECT_CALL(*store, LoadCookiesForKey(key, ::testing::_))
+        .WillOnce(::testing::SaveArg<1>(&loaded_callback));
+    EXPECT_CALL(checkpoint, Call(1));
+    // LoadCookiesForKey will never be called, because all URLs below share
+    // the same key.
+  }
+
+  {
+    GetCookieListCallback callback;
+    checkpoint.Call(0);
+    GetAllCookiesForURLTask(cm.get(), url_google_, &callback);
+    checkpoint.Call(1);
+    ASSERT_FALSE(callback.did_run());
+    // Pass the cookies to the CookieMonster.
+    loaded_callback.Run(cookies);
+    // Now GetAllCookiesForURLTask is done.
+    ASSERT_TRUE(callback.did_run());
+    // See that the callback was called with the cookies.
+    ASSERT_EQ(1u, callback.cookies().size());
+    EXPECT_TRUE(cookie.IsEquivalent(callback.cookies()[0]));
+  }
+
+  // All urls in |urls| share the same cookie domain.

[Ryan Sleevi, 2015/01/26 19:49:54]

s/share/should share/

[yhirano, 2015/01/27 02:07:10]

Done.

+  const GURL urls[] = {

[Ryan Sleevi, 2015/01/26 19:49:54]

nit NAMING: s/urls/kUrls/

[yhirano, 2015/01/27 02:07:10]

Done.

+      url_google_,
+      url_google_secure_,
+      GURL(kUrlGoogleWebSocket),
+      GURL(kUrlGoogleWebSocketSecure),
+  };
+  for (const GURL& url : urls) {
+    // Call the function with |url| and verify it is done synchronously without
+    // calling LoadCookiesForKey.
+    GetCookieListCallback callback;
+    GetAllCookiesForURLTask(cm.get(), url, &callback);
+    ASSERT_TRUE(callback.did_run());
+    ASSERT_EQ(1u, callback.cookies().size());
+    EXPECT_TRUE(cookie.IsEquivalent(callback.cookies()[0]));
+  }
+}
+
 TEST_F(CookieMonsterTest, InvalidExpiryTime) {
   std::string cookie_line =
       std::string(kValidCookieLine) + "; expires=Blarg arg arg";
   scoped_ptr<CanonicalCookie> cookie(
       CanonicalCookie::Create(url_google_, cookie_line, Time::Now(),
                               CookieOptions()));
   ASSERT_FALSE(cookie->IsPersistent());
 }
 
 // Test that CookieMonster writes session cookies into the underlying
@@ skipping 255 matching lines @@
   scoped_ptr<CookieStore::CookieChangedSubscription> sub1(
       monster()->AddCallbackForCookie(test_url_, "abc",
           base::Bind(&RecordCookieChanges, &cookies1, nullptr)));
   SetCookie(monster(), test_url_, "abc=def");
   base::MessageLoop::current()->RunUntilIdle();
   EXPECT_EQ(1U, cookies0.size());
   EXPECT_EQ(1U, cookies0.size());
 }
 
 }  // namespace net