GetEffectiveDomain should handle ws scheme as same as http scheme.

net/cookies/cookie_util_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string>
 #include <utility>
 #include <vector>
 
 #include "base/basictypes.h"
+#include "net/base/registry_controlled_domains/registry_controlled_domain.h"
+#include "net/base/registry_controlled_domains/test_util.h"
 #include "net/cookies/cookie_util.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace {
 
 struct RequestCookieParsingTest {
   std::string str;
   std::vector<std::pair<std::string, std::string> > parsed;
 };
 
@@ skipping 16 matching lines @@
 }
 
 void CheckSerialize(
     const std::vector<std::pair<std::string, std::string> >& parsed,
     const std::string& str_expected) {
   net::cookie_util::ParsedRequestCookies prc =
       MakeParsedRequestCookies(parsed);
   EXPECT_EQ(str_expected, net::cookie_util::SerializeRequestCookieLine(prc));
 }
 
-} // namespace
-
 TEST(CookieUtilTest, TestDomainIsHostOnly) {
   const struct {
     const char* str;
     const bool is_host_only;
   } tests[] = {
     { "",               true },
     { "www.google.com", true },
     { ".google.com",    false }
   };
 
@@ skipping 129 matching lines @@
                                                std::string("\"abcdef\"")));
   tests.back().parsed.push_back(std::make_pair(std::string("otherkey"),
                                                std::string("1234")));
 
   for (size_t i = 0; i < tests.size(); i++) {
     SCOPED_TRACE(testing::Message() << "Test " << i);
     CheckParse(tests[i].str, tests[i].parsed);
     CheckSerialize(tests[i].parsed, tests[i].str);
   }
 }
+
+class CookieUtilDomainTest : public testing::Test {
+ protected:
+  void TearDown() override {
+    net::registry_controlled_domains::SetFindDomainGraph();
+  }
+};
+
+TEST_F(CookieUtilDomainTest, TestGetEffectiveDomain) {
+  net::test::registry_controlled_domains::SetFindDomainTestGraph();

[Adam Rice, 2015/01/19 05:18:56]

This should go in CookieUtilDomainTest::SetUp() for symmetry with TearDown().

[yhirano, 2015/01/19 05:56:21]

Done.

+  // Note: registry_controlled_domains::GetDomainAndRegistry is tested in its
+  // unittests.
+
+  EXPECT_EQ("", net::cookie_util::GetEffectiveDomain("http", "ac.jp"));
+  EXPECT_EQ("", net::cookie_util::GetEffectiveDomain("http", "ac.jp"));
+  EXPECT_EQ("", net::cookie_util::GetEffectiveDomain("https", "ac.jp"));
+  EXPECT_EQ("", net::cookie_util::GetEffectiveDomain("ws", "ac.jp"));
+  EXPECT_EQ("", net::cookie_util::GetEffectiveDomain("wss", "ac.jp"));
+  EXPECT_EQ("ac.jp", net::cookie_util::GetEffectiveDomain("foo", "ac.jp"));

[Adam Rice, 2015/01/19 05:18:56]

Suggestion: use "ftp" instead of "foo" here. I think it will make it clearer
that we are testing the difference in handling of http/ws schemes and other
schemes.

[yhirano, 2015/01/19 05:56:21]

Done.

+}
+
+}  // namespace