Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1065)

Issue 859503004: Expose the GamepadButton interface object (Closed)

Created:
5 years, 11 months ago by philipj_slow
Modified:
5 years, 11 months ago
Reviewers:
bajones
CC:
blink-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Expose the GamepadButton interface object https://dvcs.w3.org/hg/gamepad/raw-file/default/gamepad.html#gamepadbutton-interface IE and Firefox already expose this interface object. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188694

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/webexposed/global-interface-listing-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/modules/gamepad/GamepadButton.idl View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
philipj_slow
PTAL
5 years, 11 months ago (2015-01-19 14:27:29 UTC) #2
bajones
lgtm
5 years, 11 months ago (2015-01-20 18:04:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/859503004/1
5 years, 11 months ago (2015-01-20 20:19:27 UTC) #5
commit-bot: I haz the power
Failed to commit the patch. svn: E155010: Commit failed (details follow): svn: E155010: '/b/infra_internal/commit_queue/workdir/blink/LayoutTests/platform/linux/fast/masking' is ...
5 years, 11 months ago (2015-01-20 20:56:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/859503004/1
5 years, 11 months ago (2015-01-20 21:06:31 UTC) #10
commit-bot: I haz the power
5 years, 11 months ago (2015-01-20 21:07:09 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188694

Powered by Google App Engine
This is Rietveld 408576698