Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: ui/compositor/compositor_observer.h

Issue 859423002: Explicitly specify the ui::Compositor to DelegatedFrameHost (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Use compositor Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/compositor/compositor.gyp ('k') | ui/compositor/compositor_observer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/compositor/compositor_observer.h
diff --git a/ui/compositor/compositor_observer.h b/ui/compositor/compositor_observer.h
index 76b6c5b431d4cccd9b249e2e71ef9745ff8a9d0a..b59a01de62a783efd2739a2c682bdf2dc52c98e4 100644
--- a/ui/compositor/compositor_observer.h
+++ b/ui/compositor/compositor_observer.h
@@ -15,8 +15,6 @@ class Compositor;
// A compositor observer is notified when compositing completes.
class COMPOSITOR_EXPORT CompositorObserver {
public:
- CompositorObserver();
-
// A commit proxies information from the main thread to the compositor
// thread. It typically happens when some state changes that will require a
// composite. In the multi-threaded case, many commits may happen between
@@ -40,15 +38,9 @@ class COMPOSITOR_EXPORT CompositorObserver {
// Called when the compositor lock state changes.
virtual void OnCompositingLockStateChanged(Compositor* compositor) = 0;
- protected:
-#if defined(OS_MACOSX)
- // Debugging instrumentation for crbug.com/401630.
- // TODO(ccameron): remove this.
- friend class Compositor;
- int32 observing_count_;
-#endif
-
- virtual ~CompositorObserver();
+ // Called at the top of the compositor's destructor, to give observers a
+ // chance to remove themselves.
+ virtual void OnCompositingShuttingDown(Compositor* compositor) = 0;
};
} // namespace ui
« no previous file with comments | « ui/compositor/compositor.gyp ('k') | ui/compositor/compositor_observer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698