Issue 859393005: Revert of Mac: Enable two finger double-tap smart zoom

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 859393005: Revert of Mac: Enable two finger double-tap smart zoom (Closed)

Created:
5 years, 10 months ago by ccameron

Modified:
5 years, 10 months ago

Reviewers:
Avi (use Gerrit)

CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, nasko+codewatch_chromium.org, jam, penghuang+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, James Su

Base URL:
https://chromium.googlesource.com/chromium/src.git@contentshell

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Revert of Mac: Enable two finger double-tap smart zoom (patchset #1 id:1 of https://codereview.chromium.org/909633002/) Reason for revert: This is a suspect in the dramatic increase in crash rates noted in crbug.com/456860. The crashes are on 10.10, so there are no stack traces, so this is just a guess. Original issue's description: > Mac: Enable two finger double-tap smart zoom > > BUG=452592 > > Committed: https://crrev.com/e69b4fd53dbf2d4c1fdc82de623186d7b21c29fb > Cr-Commit-Position: refs/heads/master@{#315214} TBR=avi@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=452592 Committed: https://crrev.com/f32fbe4ba2c2d76f6319229624e2b43a37d3706a Cr-Commit-Position: refs/heads/master@{#315340}

Patch Set 1 #

Created: 5 years, 10 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -11 lines)			Patch
	M	content/browser/renderer_host/render_widget_host_view_mac.mm	View		1 chunk	+0 lines, -7 lines	0 comments	Download
	M	content/renderer/render_view_impl.cc	View		1 chunk	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ccameron

Created Revert of Mac: Enable two finger double-tap smart zoom

5 years, 10 months ago (2015-02-09 18:06:15 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/859393005/1

5 years, 10 months ago (2015-02-09 18:06:59 UTC) #2

commit-bot: I haz the power

5 years, 10 months ago (2015-02-09 18:08:56 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/f32fbe4ba2c2d76f6319229624e2b43a37d3706a
Cr-Commit-Position: refs/heads/master@{#315340}

Expand Messages | Collapse Messages