Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 859393004: Update Skia GYP and GN configs to read source lists from opts.gypi. (Closed)

Created:
5 years, 10 months ago by mtklein_C
Modified:
5 years, 10 months ago
Reviewers:
mtklein, reed1
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update Skia GYP and GN configs to read source lists from opts.gypi. Add me to OWNERS too to shut up the presubmits. I tested this locally on OS X / x86-64. Relying on the bots for the rest. BUG= Committed: https://crrev.com/9116f9f9b648f2983f156c77aca116a207b7d3fb Cr-Commit-Position: refs/heads/master@{#313365}

Patch Set 1 #

Patch Set 2 : opts_check_x86.cpp is part of opts now #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -278 lines) Patch
M skia/BUILD.gn View 4 chunks +21 lines, -99 lines 0 comments Download
M skia/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
M skia/skia_library.gypi View 1 3 chunks +0 lines, -11 lines 0 comments Download
M skia/skia_library_opts.gyp View 9 chunks +40 lines, -168 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
mtklein_C
5 years, 10 months ago (2015-01-27 17:15:33 UTC) #2
reed1
awesome! lgtm
5 years, 10 months ago (2015-01-27 18:23:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/859393004/1
5 years, 10 months ago (2015-01-27 18:25:04 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/17724) Try jobs failed on following ...
5 years, 10 months ago (2015-01-27 19:05:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/859393004/20001
5 years, 10 months ago (2015-01-27 20:23:16 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-01-27 21:52:17 UTC) #10
commit-bot: I haz the power
5 years, 10 months ago (2015-01-27 21:53:18 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9116f9f9b648f2983f156c77aca116a207b7d3fb
Cr-Commit-Position: refs/heads/master@{#313365}

Powered by Google App Engine
This is Rietveld 408576698