Allow mojo::system::RawChannel::Delegate methods to destroy the RawChannel.

Allow mojo::system::RawChannel::Delegate methods to destroy the RawChannel.

(In addition to calling |Shutdown()|.)

R=yzshen@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/85edf249ee40c314f74f44e1253982c0a4175ac2

[yzshen1, 2015-01-21 23:03:42]

https://codereview.chromium.org/859333004/diff/1/mojo/edk/system/raw_channel.cc
File mojo/edk/system/raw_channel.cc (left):

https://codereview.chromium.org/859333004/diff/1/mojo/edk/system/raw_channel....
mojo/edk/system/raw_channel.cc:267: if (read_stopped_) {
Without this NOTREACHED(), maybe we should add more comments for
OnShutdownNoLock(), saying that after OnShutdownNoLock() subclasses shouldn't
make any OnReadCompleted() call.

https://codereview.chromium.org/859333004/diff/1/mojo/edk/system/raw_channel.h
File mojo/edk/system/raw_channel.h (right):

https://codereview.chromium.org/859333004/diff/1/mojo/edk/system/raw_channel....
mojo/edk/system/raw_channel.h:295: // |write_lock_| held.
Maybe also add the same comment as that of On{Read,Write}Completed

https://codereview.chromium.org/859333004/diff/1/mojo/edk/system/raw_channel_...
File mojo/edk/system/raw_channel_unittest.cc (right):

https://codereview.chromium.org/859333004/diff/1/mojo/edk/system/raw_channel_...
mojo/edk/system/raw_channel_unittest.cc:618: TEST_F(RawChannelTest,
ShutdownAndDestroyOnReadMessage) {
An alternative is to use value parameterized tests (TEST_P). That might reduce
some redundency.

[viettrungluu, 2015-01-21 23:34:32]

Thanks, PTAL.

https://codereview.chromium.org/859333004/diff/1/mojo/edk/system/raw_channel.cc
File mojo/edk/system/raw_channel.cc (left):

https://codereview.chromium.org/859333004/diff/1/mojo/edk/system/raw_channel....
mojo/edk/system/raw_channel.cc:267: if (read_stopped_) {
On 2015/01/21 23:03:42, yzshen1 wrote:
> Without this NOTREACHED(), maybe we should add more comments for
> OnShutdownNoLock(), saying that after OnShutdownNoLock() subclasses shouldn't
> make any OnReadCompleted() call.

Done.

https://codereview.chromium.org/859333004/diff/1/mojo/edk/system/raw_channel.h
File mojo/edk/system/raw_channel.h (right):

https://codereview.chromium.org/859333004/diff/1/mojo/edk/system/raw_channel....
mojo/edk/system/raw_channel.h:295: // |write_lock_| held.
On 2015/01/21 23:03:42, yzshen1 wrote:
> Maybe also add the same comment as that of On{Read,Write}Completed

Done.

https://codereview.chromium.org/859333004/diff/1/mojo/edk/system/raw_channel_...
File mojo/edk/system/raw_channel_unittest.cc (right):

https://codereview.chromium.org/859333004/diff/1/mojo/edk/system/raw_channel_...
mojo/edk/system/raw_channel_unittest.cc:618: TEST_F(RawChannelTest,
ShutdownAndDestroyOnReadMessage) {
On 2015/01/21 23:03:42, yzshen1 wrote:
> An alternative is to use value parameterized tests (TEST_P). That might reduce
> some redundency.

I don't think it's worth the extra complication (test fixture, more
conditionals) for something so small....

[yzshen1, 2015-01-21 23:37:13]

lgtm

[viettrungluu, 2015-01-22 00:01:33]

Committed patchset #2 (id:20001) manually as
85edf249ee40c314f74f44e1253982c0a4175ac2 (presubmit successful).