Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 859303004: [cast] Force 4:2:0 pixel formats in H264VideoToolboxEncoder. (Closed)

Created:
5 years, 11 months ago by jfroy
Modified:
5 years, 11 months ago
Reviewers:
hclam, miu
CC:
chromium-reviews, hclam+watch_chromium.org, imcheng+watch_chromium.org, hguihot+watch_chromium.org, jasonroberts+watch_google.com, avayvod+watch_chromium.org, pwestin+watch_google.com, feature-media-reviews_chromium.org, miu+watch_chromium.org, hubbe+watch_chromium.org, mikhal+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[cast] Force 4:2:0 pixel formats in H264VideoToolboxEncoder. On some platforms, notably the iOS simulator, VideoToolbox compression sessions vend 4:2:2 pixel buffers by default. This is not supported by the VideoFrame-CVPixelBuffer integration code. This patch forces VideoToolbox to vend I420 or NV12 buffers. For encoders that natively support those formats, this effectively changes nothing. For encoders that do not, VideoToolbox will convert submitted frames to whatever format the encoder wants. In practice, this is a defensive patch that also allows testing iOS cast streaming on the iOS simulator. BUG=450804 R=miu, hclam Committed: https://crrev.com/8813c543acf046b68183d32ef5321bce882db586 Cr-Commit-Position: refs/heads/master@{#313103}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add <vector> include #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -2 lines) Patch
M media/cast/sender/h264_vt_encoder.cc View 1 3 chunks +28 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
jfroy
5 years, 11 months ago (2015-01-21 23:50:21 UTC) #1
miu
lgtm https://codereview.chromium.org/859303004/diff/1/media/cast/sender/h264_vt_encoder.cc File media/cast/sender/h264_vt_encoder.cc (right): https://codereview.chromium.org/859303004/diff/1/media/cast/sender/h264_vt_encoder.cc#newcode278 media/cast/sender/h264_vt_encoder.cc:278: const int formats[] = { Wow. This is ...
5 years, 11 months ago (2015-01-22 00:01:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/859303004/20001
5 years, 11 months ago (2015-01-22 17:18:46 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/25886)
5 years, 11 months ago (2015-01-22 19:41:43 UTC) #6
jfroy
Unrelated test (PolicyPathParserTests.AllPlatformVariables) is failing on mac_chromium_rel_ng. I'll rebase and wait a little bit.
5 years, 11 months ago (2015-01-22 19:44:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/859303004/20001
5 years, 11 months ago (2015-01-23 22:54:17 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/25886)
5 years, 11 months ago (2015-01-23 22:55:00 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/859303004/40001
5 years, 11 months ago (2015-01-26 19:02:30 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 11 months ago (2015-01-26 19:51:25 UTC) #14
commit-bot: I haz the power
5 years, 11 months ago (2015-01-26 19:52:21 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/8813c543acf046b68183d32ef5321bce882db586
Cr-Commit-Position: refs/heads/master@{#313103}

Powered by Google App Engine
This is Rietveld 408576698