Chromium Code Reviews (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

Unified Diff: content/public/browser/content_browser_client.h

Issue 859213006: Cancel client auth requests when not promptable. (Closed) Base URL:
Patch Set: worker_common.js was missing a license header (also a rebase) Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/content_browser_client.h
diff --git a/content/public/browser/content_browser_client.h b/content/public/browser/content_browser_client.h
index c5c3942d749cc211489a01c8b1d6f7f22e961cd5..31959739147ca2cb4c74666050db4a9c7f1c45ef 100644
--- a/content/public/browser/content_browser_client.h
+++ b/content/public/browser/content_browser_client.h
@@ -89,6 +89,7 @@ class BrowserMainParts;
class BrowserPluginGuestDelegate;
class BrowserPpapiHost;
class BrowserURLHandler;
+class ClientCertificateDelegate;
class DevToolsManagerDelegate;
class ExternalVideoSurfaceContainer;
class LocationProvider;
@@ -400,14 +401,14 @@ class CONTENT_EXPORT ContentBrowserClient {
const base::Callback<void(bool)>& callback,
CertificateRequestResultType* result) {}
- // Selects a SSL client certificate and returns it to the |callback|. If no
- // certificate was selected nullptr is returned to the |callback|. Note:
- // |callback| may be called synchronously or asynchronously.
+ // Selects a SSL client certificate and returns it to the |delegate|. Note:
+ // |delegate| may be called synchronously or asynchronously.
+ //
+ // TODO(davidben): Move this hook to WebContentsDelegate.
virtual void SelectClientCertificate(
- int render_process_id,
- int render_frame_id,
+ WebContents* web_contents,
net::SSLCertRequestInfo* cert_request_info,
- const base::Callback<void(net::X509Certificate*)>& callback);
+ scoped_ptr<ClientCertificateDelegate> delegate);
// Adds a new installable certificate or private key.
// Typically used to install an X.509 user certificate.
« no previous file with comments | « content/public/browser/client_certificate_delegate.h ('k') | content/public/browser/ » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698