Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(922)

Unified Diff: chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa.h

Issue 859213006: Cancel client auth requests when not promptable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@client-auth-cancel-1
Patch Set: worker_common.js was missing a license header (also a rebase) Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa.h
diff --git a/chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa.h b/chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa.h
index aacdafe882a79e1c1b1cfbc97f937e0ac59e6b03..f1fe2e329fc9fabb2a677484ec5d14d4980070fd 100644
--- a/chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa.h
+++ b/chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa.h
@@ -18,6 +18,7 @@
namespace content {
class BrowserContext;
+class ClientCertificateDelegate;
}
class ConstrainedWindowMac;
@@ -41,13 +42,18 @@ class SSLClientAuthObserverCocoaBridge;
NSRect oldSheetFrame_;
// A copy of the sheet's |autoresizesSubviews| flag to restore on show.
BOOL oldResizesSubviews_;
+ // True if the user dismissed the dialog directly, either via the OK (continue
+ // the request with a certificate) or Cancel (continue the request with no
+ // certificate) buttons.
+ BOOL userResponded_;
}
@property (readonly, nonatomic) SFChooseIdentityPanel* panel;
- (id)initWithBrowserContext:(const content::BrowserContext*)browserContext
certRequestInfo:(net::SSLCertRequestInfo*)certRequestInfo
- callback:(const chrome::SelectCertificateCallback&)callback;
+ delegate:(scoped_ptr<content::ClientCertificateDelegate>)
+ delegate;
- (void)displayForWebContents:(content::WebContents*)webContents;
- (void)closeWebContentsModalDialog;

Powered by Google App Engine
This is Rietveld 408576698