Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2662)

Unified Diff: android_webview/native/aw_contents_client_bridge.h

Issue 859213006: Cancel client auth requests when not promptable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@client-auth-cancel-1
Patch Set: worker_common.js was missing a license header (also a rebase) Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/native/aw_contents_client_bridge.h
diff --git a/android_webview/native/aw_contents_client_bridge.h b/android_webview/native/aw_contents_client_bridge.h
index 2a5caba0bba5dd6dceba670b6da8e2b9533d4a10..a2bde4b02899f4789b7b6bec2db92b5a54ef26d9 100644
--- a/android_webview/native/aw_contents_client_bridge.h
+++ b/android_webview/native/aw_contents_client_bridge.h
@@ -40,7 +40,7 @@ class AwContentsClientBridge : public AwContentsClientBridgeBase {
bool* cancel_request) override;
void SelectClientCertificate(
net::SSLCertRequestInfo* cert_request_info,
- const SelectCertificateCallback& callback) override;
+ scoped_ptr<content::ClientCertificateDelegate> delegate) override;
void RunJavaScriptDialog(
content::JavaScriptMessageType message_type,
@@ -73,8 +73,10 @@ class AwContentsClientBridge : public AwContentsClientBridgeBase {
IDMap<CertErrorCallback, IDMapOwnPointer> pending_cert_error_callbacks_;
IDMap<content::JavaScriptDialogManager::DialogClosedCallback, IDMapOwnPointer>
pending_js_dialog_callbacks_;
- IDMap<SelectCertificateCallback, IDMapOwnPointer>
- pending_client_cert_request_callbacks_;
+ // |pending_client_cert_request_delegates_| owns its pointers, but IDMap
+ // doesn't provide Release, so ownership is managed manually.
+ IDMap<content::ClientCertificateDelegate>
+ pending_client_cert_request_delegates_;
};
bool RegisterAwContentsClientBridge(JNIEnv* env);
« no previous file with comments | « android_webview/browser/aw_contents_client_bridge_base.h ('k') | android_webview/native/aw_contents_client_bridge.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698